Re: [Tinycc-devel] Symbols visibility support (cont: Linking bug about _i686.get_pc_thunk.*)

[Rob Landley]

On Thursday 12 April 2007 9:06 am, Vince wrote:
> Hello,
> 
> I had the same linking problem as described in
> http://lists.gnu.org/archive/html/tinycc-devel/2007-02/msg00004.html.
> The people from the Gentoo bugzilla told me that this symbol had
> actually its visibility flag set to HIDDEN, so the linker shouldn't
> care about it (see https://bugs.gentoo.org/show_bug.cgi?id=174034).

Do you have a test case I can reproduce the bug with?  (Something I can 
compile to see it for myself?)

> From the pieces of information available at
> http://sourceware.org/ml/binutils/2003-03/msg00446.html and
> http://www.sco.com/developers/gabi/2000-07-17/ch4.symtab.html#visibility.
> I wrote a patch to set the visibility to the most restrictive one when
> a duplicate symbol is added, and then to skip it if its visibility is
> HIDDEN or INTERNAL. This seems to fix the problem.
> 
> Since I'm far from being an expert in linking, I'd be glad to hear
> your comments about this patch.

I'm not an expert on linking either, that's why I want to reproduce this to 
confirm the fix is doing the right thing. :)

I'll add the references you linked to to my to-read list and the patch to my 
todo queue.

> Regards,
> 
> Vincent Pit.

Thanks,

Rob
-- 
Penguicon 5.0 Apr 20-22, Linux Expo/SF Convention.  Bruce Schneier, Christine 
Peterson, Steve Jackson, Randy Milholland, Elizabeth Bear, Charlie Stross...