Re: [Tinycc-devel] x86-64 port

[grischka]

shinichiro.h wrote:

> I've worked on porting TCC for x86-64 and I'd like to send a patch. 
> This patch is the diff from CVS head.

Thanks. I think we definitely want this.

Please consider to contribute to our GIT repo directly.
http://repo.or.cz/w/tinycc.git

You can push to the "mob" branch without special permissions.

For a little howto, see:
http://lists.gnu.org/archive/html/tinycc-devel/2008-11/msg00035.html

The advantage is also that people can download a snapshot tarball
from there any time.

If you want I can add you as "project member" so you can work more
undisturbed on say, a "x86-64" topic branch.

Some note from a quick view:

- Try to avoid casts if it's just to get rid of gcc-warnings.
  We'd rather use a gcc-switch to disable such warnings, for now.

  Also try to separate such and other formal changes into their
  own patches. It makes it easier for other people to follow your
  actual work.  With GIT it is painless to make many small commits.

  (If it's too late now, no big problem)

- in tcc_delete: free the member before the structure :)
    tcc_free(s1->jmp_table);
    tcc_free(s1);

I personally cannot test this, but it looks like you know what
you're doing.

--- grischka