tinycc-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Tinycc-devel] Several patchs from Debian packaging


From: Rob
Subject: Re: [Tinycc-devel] Several patchs from Debian packaging
Date: Sun, 18 Apr 2010 21:38:20 +0100

>        if (libprefix && (!strncmp(ext, ".so", 2))) {
>            size_t len = ext - filename - 3;
>            strncpy(libname, filename + 3, len);
>            *(libname + len) = '\0';
>            return 1;
>        }
>
> I also wonder wether is strncmp is a good idea here as it could match .sowtf
> for example. I think strcmp is more appropriate here, don't you think ?

Couldn't help but notice, if you do use strncmp, shouldn't it be
>strncmp(ext, ".so", 3)
instead of 2?
or
>strncmp(ext, "so", 2)




reply via email to

[Prev in Thread] Current Thread [Next in Thread]