tinycc-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Tinycc-devel] Small patch


From: grischka
Subject: Re: [Tinycc-devel] Small patch
Date: Thu, 31 Jan 2013 14:50:38 +0100
User-agent: Thunderbird 2.0.0.23 (Windows/20090812)

Vincent Lefevre wrote:
On 2013-01-31 13:22:22 +0100, grischka wrote:
Vincent Lefevre wrote:
Perhaps there was a "default:" by default the author forgot to remove.
And as it is probably just useless (if op can only be '&', '|' or '^'),
no-one noticed it.
I guess it was to avoid a compiler warning such as
        "case X not handled in switch"

In such a case, a "default:" at the end with an assertion failure
would have been better.


No.  An assertion only makes sense to make sure about what we aren't
entirely sure.  In this case we are sure (that "default" never happens).

--- grischka




reply via email to

[Prev in Thread] Current Thread [Next in Thread]