[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Tinycc-devel] Patch to correct using incomplete types in structures
From: |
Thomas Preud'homme |
Subject: |
Re: [Tinycc-devel] Patch to correct using incomplete types in structures/unions. |
Date: |
Tue, 15 Oct 2013 04:51:19 +0200 |
User-agent: |
KMail/1.13.7 (Linux/2.6.38-ac2-ac100; KDE/4.8.4; armv7l; ; ) |
Le dimanche 6 octobre 2013 15:30:13, Amine Najahi a écrit :
> Hi Thomas,
Hi Amine,
>
> You are definitely right, I corrected it in my commit.
Great.
>
> You're right again, that is what I intented to do, but ended up copy
> pasting the
> message and forgetting to change it.
Oh yeah, that happens.
>
> > If you can change this, test that all tests still work then you can
> > commit it.
>
> I committed the changes to the mob branch.
Great, thanks for your work.
>
> > Thanks a lot for your work on this Amine. I hope you don't mind my small
> > criticism, I really appreciate your work.
>
> I don't mind at all. My knowledge of tcc is almost null and your remarks
> were
> pertinent.
Believe me, even I have still to lean. Feel free to propose more patch, New
contributors are definitively welcome for tcc.
>
> Amine
Best regards,
Thomas