[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Tinycc-devel] Use an anonymous file to back mmap
From: |
Thomas Preud'homme |
Subject: |
Re: [Tinycc-devel] Use an anonymous file to back mmap |
Date: |
Fri, 10 Jan 2014 14:32:28 +0800 |
User-agent: |
KMail/4.11.3 (Linux/2.6.38-ac2-ac100; KDE/4.11.3; armv7l; ; ) |
Le jeudi 9 janvier 2014, 14:21:59 Keren Tan a écrit :
> Hi All,
>
> I just submitted a tentative patch to the mob branch about mmap. When
> selinux is enabled, tccrun.c uses mmap to hold the dynamically generated
> code/data. It is backed by a randomly named file under /tmp directory. My
> patch is to use an anonymous file in mmap instead, so that the generated
> code/data only resides in memory, and tcc does not depend on a writable
> /tmp anymore.
>
> tcc is fantastic! I am new to this community. Your comments are very
> welcome!
Here is my comment: you removed the line s1->mem_size = ret; which is used to
unmap these memory regions in libtcc.c
>
> http://repo.or.cz/w/tinycc.git/commit/935d8169b8e3570f1a5e726c5295be2f460c15
> 40
>
> Best,
> Keren Tan
Thanks for your patch.
Best regards,
Thomas