[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Tinycc-devel] [PATCH] libtcc.c (put_extern_sym2): Extend the scope
From: |
Thomas Preud'homme |
Subject: |
Re: [Tinycc-devel] [PATCH] libtcc.c (put_extern_sym2): Extend the scope of buf to match its use |
Date: |
Sat, 03 Jan 2015 21:26:40 +0000 |
User-agent: |
KMail/4.14.1 (Linux/2.6.38-ac2-ac100; KDE/4.14.2; armv7l; ; ) |
Le jeudi 18 décembre 2014, 20:00:02 David Mertens a écrit :
> Good catch. I'm not closely acquainted with this particular section of
> code, but your observation looks correct to me, and the fix looks right.
I have 2 minor nitpick though (I know it's already commited). First, with that
change buf is no longer declared at the start of a block (C89 style) and this
is the coding style used in tcc. Second, it would be more consistent and
clearer to declare it in the same scope as name since they are both used in
the same scope.
Best regards,
Thomas
- Re: [Tinycc-devel] [PATCH] libtcc.c (put_extern_sym2): Extend the scope of buf to match its use,
Thomas Preud'homme <=