[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Tinycc-devel] [PATCH] accepting a 'b' suffix at the end of all the
|
From: |
Thomas Preud'homme |
|
Subject: |
Re: [Tinycc-devel] [PATCH] accepting a 'b' suffix at the end of all the setcc instructions |
|
Date: |
Sun, 04 Jan 2015 01:18:33 +0000 |
|
User-agent: |
KMail/4.14.1 (Linux/2.6.38-ac2-ac100; KDE/4.14.2; armv7l; ; ) |
Le samedi 3 janvier 2015, 09:34:14 Sergey Korshunoff a écrit :
> Allow tcc to understand a setob,... opcodes as alias to seto,...
>
> PS:
> http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20101122/112576
> .html This is fix PR8686 for llvm: accepting a 'b' suffix at the end of all
> the setcc instructions
Hi Sergey,
As said previously I'm not very familiar with this part of the code but your
change looks good. I just have one suggestion:
rename DEF_ASMTEST by DEF_ASMTEST_SUF and make it take a third parameter that
is concatenated at the end. Then make DEF_ASMTEST call DEF_ASMTEST_SUF and you
can define DEF_ASMTEST_SET with DEF_ASM_SUF as well using less lines overall.
By the way, is it normal that there is only 2 variants of set for x86_64 but
so many for i386?
Best regards,
Thomas