[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Tinycc-devel] [PATCH] TCC arm64 back end
From: |
Michael Matz |
Subject: |
Re: [Tinycc-devel] [PATCH] TCC arm64 back end |
Date: |
Sun, 22 Feb 2015 17:02:55 +0100 (CET) |
User-agent: |
Alpine 2.00 (LNX 1167 2008-08-23) |
Hi,
On Sun, 22 Feb 2015, Edmund Grimley Evans wrote:
That's excellent. Many thanks. When do you sleep, by the way? :-)
Roughly when you asked this question :)
- merge my local uncommitted stuff or at least stash it somehow
(I've implemented HFAs and have started doing va_list)
- rebase my branch onto the latest mob, omitting the VT_LLOCAL/'.' patch
- merge your patch
- send out the new diff, which should then demonstrate the problem when
you do: ( cd tests && make abitest )
(I'll fiddle with the patch you sent)
I'm not a git expert, but what I'll try to do before committing the
arm64 branch to mob is greatly simplify the history but leave your
changes to tccelf.c as a separate commit ... so that anyone who consults
the history will know who the expert is on linking!
I'm hoping the arm64 stuff can go onto mob within about a week even if
it's without va_list.
Just push the stuff right now to mob. Makes collaboration a bit easier
than having to deal with the large patch by hand. As for history: make
sure the branch you push doesn't contain any merges (uglifies history),
i.e. your working-mob branch should always have been rebased, not merged
with origin/mob. One more request: if you could make sure that multi-line
comments in your patch are using /**/ and no leader chars, that would be
ideal.
Ciao,
Michael.