tinycc-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Tinycc-devel] VLAs broken on mob branch


From: Sergey Korshunoff
Subject: Re: [Tinycc-devel] VLAs broken on mob branch
Date: Mon, 27 Apr 2015 06:18:36 +0300

> on x86 Linux a similar patch of the gfunc_call (i386-gen.c) leads to
> the hang on the test3.

> It looks that
>
> @@ -5458,6 +5459,7 @@ static void decl_initializer(CType *type,
> Section *sec, unsigned long c,
>
>          vla_runtime_type_size(type, &a);
>          gen_vla_alloc(type, a);
> +        vla_sp_save();
>          vset(type, VT_LOCAL|VT_LVAL, c);
>          vswap();
>          vstore();
>
> is enough to fix a problem.

> That doesn't appear to fix the problem for me (on x86_64), without the
> other changes. Are you sure it's sufficient for you?

Just tested: on x86 a problem is fixed by changes for case 1..3, i.e.
w/o additional vla_sp_save().

I think this patch can be pushed to the mob (w/o addtional vla_sp_save).



reply via email to

[Prev in Thread] Current Thread [Next in Thread]