Re: [Tinycc-devel] revert of "Identifiers can start and/or contain"

[Sergey Korshunoff]

> Btw, I had some fixes for the last patches I sent to the list that I only
> pushed to my github branch. Will rebase on latest mob and push them
> directly.

gcc 3.4.6:
tccpp.c: In function `pragma_parse':
tccpp.c:1484: warning: implicit declaration of function `strupr'
/tmp/ccpPeLEQ.o: In function `pragma_parse':
/WORK/WORK/tinycc.git/tccpp.c:1484: undefined reference to `strupr'

Which compiler are you used?
#if PATHCMP==stricmp
        strupr(buf1);
#endif

gcc 3.4.6 don't understand this.
Suggested change:
-#if PATHCMP==stricmp
+#ifdef _WIN32

2016-04-13 10:46 GMT+03:00, Vladimir Vissoultchev <address@hidden>:
> Nice catch! Sorry I missed the extra '.' in the original patch.
>
> Btw, I had some fixes for the last patches I sent to the list that I only
> pushed to my github branch. Will rebase on latest mob and push them
> directly.
>
> About `ppfp` being NULL, I saw most of the code has guards, obviously
> missed
> a few places that don't. Will impl these and keep `ppfp` NULL when no
> preprocessor output is expected.
>
> cheers,
> </wqw>
>
> -----Original Message-----
> From: Tinycc-devel
> [mailto:address@hidden
> On Behalf Of Sergey Korshunoff
> Sent: Wednesday, April 13, 2016 10:33 AM
> To: address@hidden
> Subject: Re: [Tinycc-devel] revert of "Identifiers can start and/or
> contain"
>
> Hi!
> A correct version of the patch is pushed to the [mob] A problem was in
> TOK_ASMDIR_text:
>         -    sprintf(sname, ".%s", get_tok_str(tok1, NULL));
>         +    sprintf(sname, "%s", get_tok_str(tok1, NULL));
>         When tok1 is '.text', then sname is '..text'
>
> _______________________________________________
> Tinycc-devel mailing list
> address@hidden
> https://lists.nongnu.org/mailman/listinfo/tinycc-devel
>
>
> _______________________________________________
> Tinycc-devel mailing list
> address@hidden
> https://lists.nongnu.org/mailman/listinfo/tinycc-devel
>