tinycc-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Tinycc-devel] TOK_PPNUM for asm


From: Edmund Grimley Evans
Subject: Re: [Tinycc-devel] TOK_PPNUM for asm
Date: Thu, 5 May 2016 00:12:55 +0100
User-agent: Mutt/1.5.21 (2010-09-15)

> > Proposed patch: handle 0x1e+1 as 0x1e +1 if (parse_flags & 
> > PARSE_FLAG_ASM_FILE)
> 
> Please explain and justify exactly what you're trying to do. What do
> you believe the correct definition of a pp-number is when tokenising
> assembly? What definition does the GNU toolchain use?

Also, presumably there's a good reason why your patch modified 43
lines, rather than just one, as below. What is that reason?

diff --git a/tccpp.c b/tccpp.c
index ad35687..7dd6d36 100644
--- a/tccpp.c
+++ b/tccpp.c
@@ -2766,6 +2766,7 @@ maybe_newline:
                   || c == '.'
                   || ((c == '+' || c == '-')
                       && (t == 'e' || t == 'E' || t == 'p' || t == 'P')
+                      && !(parse_flags & PARSE_FLAG_ASM_FILE)
                       )))
                 break;
         }



reply via email to

[Prev in Thread] Current Thread [Next in Thread]