Re: [Tinycc-devel] spawnvp V.S. _spawnvp on Windows

[Christian Jullien]

I pushed this small patch:

 

diff --git a/tcc.c b/tcc.c

index 93ed4de..b340d9b 100644 (file)

--- a/tcc.c

+++ b/tcc.c

@@ -133,7 +133,7 @@ static void help(void)

 #include <process.h>

 static int execvp_win32(const char *prog, char **argv)

 {

-    int ret = spawnvp(P_NOWAIT, prog, (const char *const*)argv);

+    int ret = _spawnvp(P_NOWAIT, prog, (const char *const*)argv);

     if (-1 == ret)

         return ret;

     cwait(&ret, ret, WAIT_CHILD);

 

 

From: Tinycc-devel [mailto:address@hidden On Behalf Of Christian Jullien
Sent: lundi 16 mai 2016 10:12
To: address@hidden
Subject: [Tinycc-devel] spawnvp V.S. _spawnvp on Windows

 

Hi,

 

When I build tinycc on Windows (both 32/64 bit).

 

I always get this warning:

 

../tcc.c:136:39: warning: passing argument 3 of 'spawnvp' from incompatible pointer type [-Wincompatible-pointer-types]

     int ret = spawnvp(P_NOWAIT, prog, (const char *const*)argv);

 

Looking a spawnvp documentation from Microsoft, I get:

 

This POSIX function is deprecated. Use the ISO C++ conformant spawnvp instead.

 

So I replaced spawnvp by _spawnvp and no more warning when using mingw32/64 gcc compilers.

 

Please Windows maintainer (if any), can you consider this very simple change?

 

Christian