tinycc-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Tinycc-devel] Add support for Unicode entries 'wmain' and 'wWinMain


From: YX Hao
Subject: Re: [Tinycc-devel] Add support for Unicode entries 'wmain' and 'wWinMain' on Windows
Date: Sat, 18 Feb 2017 17:33:41 +0800

Hoping some experienced one can fix it.
I am not using ' Cygwin', and didn't touch the 'Win32/Makefile' and ' 
lib/Makefile'. Christian and grischka have pushed commits. Thanks!
Also 'configure' file and related files are complicate for me, I am not going 
to mess it up :(

> -----Original Message-----
> From: address@hidden [mailto:tinycc-
> address@hidden On Behalf Of avih
> Sent: Saturday, February 18, 2017 3:23 PM
> To: address@hidden
> Subject: Re: [Tinycc-devel] Add support for Unicode entries 'wmain' and
> 'wWinMain' on Windows
> 
> This caused tests failures on windows (gcc, normal configure and make, the 
> build
> succeeds) - missing symbol "main" when running libtcc test, and many later 
> tests
> too which probably use libtcc in memory.
> 
> Attached are two orthogonal patches, i.e. the test failures happen with or
> without also building the unicode variants of the crt files, and the tests 
> pass
> (with the tccpe.c fix) regardless if building with or without the unicode 
> variants.
> 
> I'm not entirely sure the tccpe.c fix is correct, and also not sure whether 
> the
> wrapper c file is an acceptable solution for re-compiling the same files with
> different defines and to different .o files. Please either someone pushes a 
> better
> fix, or tell me how to improve the patches, or just tell me to push it as is.
> 
> Thanks.
> 
> On Thursday, February 16, 2017 10:35 PM, grischka <mailto:address@hidden>
> wrote:
> 
> YX Hao wrote:
> > Dear grischka and group,
> > Unicode entry support for windows platform is useful. Especially when
> > developing programs which relays on the Unicode version APIs and takes
> > Unicode arguments, it will help.
> >
> > Here is my patch for this feature. I have used it for about 1 year. It has
> > followed the recent commits
> (7b99c3ac2c9c1761d68be1192f975a39199be28d).
> >
> > '-run' option is useable. And arguments converted.
> >
> > Since I'm not experienced as you guys. Please give me a review.
> 
> Looks good.  Please push.  I will adjust the Makefiles later.
> 
> Thanks,
> 
> 
> --- grischka
> 
> >
> > Best Regards,
> >
> > YX Hao
> >

_______________________________________________
Tinycc-devel mailing list
mailto:address@hidden
https://lists.nongnu.org/mailman/listinfo/tinycc-devel






reply via email to

[Prev in Thread] Current Thread [Next in Thread]