Re: [Tinycc-devel] [PATCH] win32: add include/getopt.h with static implementation

[avih]

Hi Michael,

> > Patch is attached. If there are no objections, I'll push it in few days.
>
> But why? TCC is a compiler, it doesn't generally provide a C library.
> Use newlib or musl or the like for that.

You know as well as anyone that the Windows build of tcc is more than
that. It's a self contained vertical package which includes everything
required to build many programs without further dependencies. So your
statement, while correct in general, is not so true for Windows.

Most CLI programs process arguments, and getopt is the standard.


> The underlying objection is basically the answer to the question "where
> do you stop?"

Indeed that is the real question, and the only relevant question IMHO,
to which I don't have an answer, but I think it's along the lines of
"small and generally useful, not full blown".

I'm not familiar with TCC guidelines, official or not, to use it with
newlib or musl. If there were such then I'd agree getopt should not be
part of tcc itself, but I think it's not trivial on Windows, and this
patch is very small in the grand scheme of things, and provides a very
useful functionality.


> So, please no.

So do you have a concrete answer to "where do we stop", or guidelines
to use musl or newlib with tcc for windows?

If yes, then the text should be incorporated into the repo IMO.

If no, then I think getopt has good value and low risk/complexity,
which IMHO makes it worth including for the Windows build.

Cheers,
Avi