[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Tinycc-devel] Request for "fix float to u64 intrinsics"

From: Christian Jullien
Subject: [Tinycc-devel] Request for "fix float to u64 intrinsics"
Date: Fri, 11 Sep 2020 05:49:53 +0200

Hi Kyryl,


First I personally appreciate you want to make tcc even better.

Unfortunately your fixes are unclear about what they fix.

It’s hard to see if they don’t introduce a regression on another platform. For example, long double has not the same precision on x64 or on Aarch64. It easy to make a fix on a plateform that introduces a regression on another.

I understand that you can’t test on all supported platforms but a new test in test suite can help us to understand what was the bug and if your patches fix it on all supported plateforms.

Can you please add an almost complete set of tests that prove that tcc was previously wrong and that now, it fixes them all.

For example, I suggest you add those tests (with a little comment) on 22_floating_point.c


$ make && make test


Then I’ll be glad to test it works on all supported platforms.


Also, as a matter of style, we prefer a space between if and ( in _expression_ like if(SIGN(fl1.l)).

Style with space occurs 4015 times while style w.o. space occurs only 154 times.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]