Re: [Tinycc-devel] Making tinycc fully reentrant

[Domingo Alvarez Duarte]

Hello Christian !

Thank you for reply !

I also noticed that there was some problems when trying to compile for 
arm64 on Android under termux.

I'll put my changes here now https://github.com/mingodad/tinycc.

I did reverted all my changes !

Cheers !

On 22/10/21 6:00, Christian Jullien wrote:
> Hi Domingo,
> Thank you for your attempt to make tcc better. However, please never commit 
> huge changes like this without making a branch before **and** ask maintainers 
> if they agree (I'm not a maintainer but an enthusiast user).
> So I strongly suggest you revert your all changes as, among others, it breaks
>
> - Windows:
> ../tccpe.c:871: warning: assignment from incompatible pointer type
> In file included from ../tcc.c:25:
> ../tcctools.c:442: error: 'S' undeclared
>
> - macOS
> In file included from tcc.c:21:
> In file included from ./tcc.h:362:
> ./libtcc.h:28:16: error: typedef redefinition with different types ('long' vs 
> '__darwin_off_t' (aka 'long long'))
>    typedef long off_t;
>                 ^
> /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/sys/_types/_off_t.h:31:33:
>  note: previous definition is here
> typedef __darwin_off_t          off_t;
>
> Christian
>
> -----Original Message-----
> From: Tinycc-devel [mailto:tinycc-devel-bounces+eligis=orange.fr@nongnu.org] On 
> Behalf Of Domingo Alvarez Duarte
> Sent: Thursday, October 21, 2021 20:19
> To: tinycc-devel@nongnu.org
> Subject: [Tinycc-devel] Making tinycc fully reentrant
>
> Hello !
>
> I did it once in the past and did again moving almost all global
> variables to TCCState and on Ubuntu 18.04 x86_64 all tests from "make
> test" pass.
>
> It's a massive refactoring (3 full working days).
>
> Any comments/suggestions are welcome !
>
> Cheers !
>
>
> _______________________________________________
> Tinycc-devel mailing list
> Tinycc-devel@nongnu.org
> https://lists.nongnu.org/mailman/listinfo/tinycc-devel
>
>
> _______________________________________________
> Tinycc-devel mailing list
> Tinycc-devel@nongnu.org
> https://lists.nongnu.org/mailman/listinfo/tinycc-devel