Re: [Tinycc-devel] Fwd: [PATCH] freebsd support update proposal

[grischka]

David CARLIER wrote:
> Hi if nobody objects, I may apply the last aforementioned patch
> sometime next week.

Since you asked:

> --- a/tests/tests2/46_grep.c
> +++ b/tests/tests2/46_grep.c
> @@ -14,6 +14,9 @@
>   * included and reference made to  the  fact  that  reproduction
>   * privileges were granted by DECUS.
>   */
> +#if defined(__FreeBSD__)
> +#include <sys/cdefs.h>
> +#endif
>  #include <stdio.h>
>  #include <stdlib.h>
>  #include <ctype.h>       // tolower()

- what is this (nobody will know without a comment)
- sys/cdefs.h is not that a user file should include
- 46_grep.c looks really "innocent" enough that it should compile
  OOTB on any C and platform
- in general, when tests fail, we want the problem be fixed, not the test

Maybe you can find a better solution, or maybe someone else can...

-- gr

> Kind regards.