tinycc-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Tinycc-devel] randomly failing tests


From: NightStrike
Subject: Re: [Tinycc-devel] randomly failing tests
Date: Wed, 28 Dec 2022 10:07:19 -0500



On Wed, Dec 28, 2022, 06:46 Vincent Lefevre <vincent@vinc17.net> wrote:
On 2022-12-28 06:00:11 -0500, NightStrike wrote:
> On Wed, Dec 28, 2022, 03:31 Christian Jullien <eligis@orange.fr> wrote:
> > diff --git a/Makefile b/Makefile
> > index c220879..c718d7a 100644
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -447,14 +447,16 @@ config.mak:
> >         $(if $(wildcard $@),,@echo "Please run ./configure." && exit 1)
> >
> >  # run all tests
> > +SERIALIZE = -j1
> > +
> >  test:
> > -       @$(MAKE) -C tests
> > +       @$(MAKE) $(SERIALIZE) -C tests
> >  # run test(s) from tests2 subdir (see make help)
> >  tests2.%:
> > -       @$(MAKE) -C tests/tests2 $@
> > +       @$(MAKE) $(SERIALIZE) -C tests/tests2 $@
> >
> >  testspp.%:
> > -       @$(MAKE) -C tests/pp $@
> > +       @$(MAKE) $(SERIALIZE) -C tests/pp $@
> >
> >  clean:
> >         @rm -f tcc$(EXESUF) tcc_p$(EXESUF) *-tcc$(EXESUF) tags ETAGS *.pod
>
> I think what you want is .NOTPARALLEL:
>
> https://www.gnu.org/software/make/manual/html_node/Parallel-Disable.html

Perhaps, but the issue with ".NOTPARALLEL" is that it applies to
the full Makefile, in case one just wants to serialize some tests.

You can give it prerequisites to overcome that.

However, Herman ten Brugge fixed the issue yesterday in
commit 7ed9c95ae795dd71c624ffb0d82f267b2c9697af to allow
a parallel build. I've just checked that it works. Thanks!

Yes, this is the better solution :)

reply via email to

[Prev in Thread] Current Thread [Next in Thread]