[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Clean up Tramp version check
From: |
Michael Albinus |
Subject: |
Re: [PATCH] Clean up Tramp version check |
Date: |
Sun, 12 Jul 2020 15:48:40 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
Nicholas Drozd <nicholasdrozd@gmail.com> writes:
Hi Nicholas,
> This turned out to be quite a piece of code indeed. I think this
> change respects all the existing requirements. As I said before, this
> shouldn't change any behavior, apart from adding the new function and
> variable. Feel free to reject.
Thanks. However,
> + (let ((tramp-minimum-emacs-version "30.1"))
> + (should-error (tramp-check-version))))
this does not work as expected. What is this check good for? I
understand your intention, but do we need to test this case?
Best regards, Michael.