Re: [Traverso-devel] Fade View classes added to CVS

[Nicola Doebelin]

Am Donnerstag, 3. August 2006 16:50 schrieb Remon Sijrier:
> Things that needs some love is:
> - Correct loading from xml file
> - jmbfade only had support for Fade IN, and not Fade OUT
>
> Nicola, can you give me some help to create the Fade OUT part ?

Could you check if in your version of jmbfade there is a line 'direction = 
FADE_IN;' in the constructor? My most recent version works in both 
directions, maybe yours is not up to date.

> The FadeCurve now consist of 10 nodes, which seems to be sufficient to
> create a smooth curve. If more are needed, no problem, just let me know

Should be ok for the monotone curve. Does it still look smooth for the S-type 
curve? If not we should probably use spline interpolation in the dialog as 
well, to make it look nicer.

> Nicola, your jmbfade doesn't understand a Curve with nodes, instead it
> makes one...
> The problem arising now is, when the dialog is shown, it resets the
> FadeCurve to the default as created by the jmbfade.
>
> I was thinking, maybe it's even better to store the bend, strenght and
> strength points into an xml file, and _always_ create the nodes from there?

I think the easiest solution would be to store the curve parameters somewhere 
in order to restore the curve. The parent class does not have to 'understand' 
these values (bending, strength, mode, direction etc.), just store them and 
send them to the fade dialog whenever it is shown.

(AFAIK there is no way to restore the curve from the nodes without using a 
fitting algorithm, so we need to keep the control parameters somewhere.)

> It's actually a nice thing to have, since it simplifies the xml scheme, and
> also the Dialog code, by moving the calculations of the Curve (from the
> jmbfade) to FadeCurve class.

Sure, if it is easier I'm all for it :-)

> Apart from the rough edges, it seems to work really nice :-)

Great!

Nic

P.S. Is it in the 0.30.1 release?