[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: vm, emacs 28.2 (debian), urls in minibuffer
From: |
John Stoffel |
Subject: |
Re: vm, emacs 28.2 (debian), urls in minibuffer |
Date: |
Thu, 8 Feb 2024 11:29:08 -0500 |
>>>>> "Stefan" == Stefan Monnier via General discussion of VM mail reader
>>>>> <viewmail-info@nongnu.org> writes:
>> This is a great start! I will apply this to my local tree and see how
>> it works.
> I'd be surprised if it works well enough as-is. But feel free to ask me
> about problems you encounter (or about compiler warnings you don't know
> how to address).
Can you tell me which version of VM you did your diff from? It's not
applying cleanly to a fresh release of 8.2.0b, so I'm going to have to
do more work here.
>> So which versions of Emacs have you tested this on?
> None: guaranteed 100% untested.
LOL! I'll let you know how it goes!
>> I'll be testing on Emacs 28.2, and it looks like you use XEmacs,
> I used to be maintainer of Emacs, so no, not XEmacs.
>> just judging from the changes you made in this patch.
> The changes about (featurep 'xemacs) are made because the compiler knows
> that (featurep 'xemacs) returns nil and can thus optimize things away,
> whereas if you test a variable (such as `vm-xemacs-p`) the compiler
> doesn't notice that this var will always be nil.
Nice, that's a good cleanup no matter what. If I setup a github repo
with the base 8.2.0b, would that be a good base to work off of?
I'm really useless with lisp programming unfortunately, and I'm going
to be super busy over the next week with other stuff to spend a ton of
time on this, but I will try to do what I can.
John
- Re: vm, emacs 28.2 (debian), urls in minibuffer, John Stoffel, 2024/02/07
- Re: vm, emacs 28.2 (debian), urls in minibuffer, Stefan Monnier, 2024/02/07
- Re: vm, emacs 28.2 (debian), urls in minibuffer,
John Stoffel <=
- Re: vm, emacs 28.2 (debian), urls in minibuffer, Stefan Monnier, 2024/02/08
- Re: vm, emacs 28.2 (debian), urls in minibuffer, John Stoffel, 2024/02/08
- Re: vm, emacs 28.2 (debian), urls in minibuffer, Stefan Monnier, 2024/02/08