wget-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: wget2 | * tests/test-timestamping.c: Pass correct type to variadic f


From: Avinash Sonawane (@rootkea)
Subject: Re: wget2 | * tests/test-timestamping.c: Pass correct type to variadic function (!538)
Date: Sun, 14 Jan 2024 17:06:24 +0000



Avinash Sonawane commented on a discussion on tests/test-timestamping.c: 
https://gitlab.com/gnuwget/wget2/-/merge_requests/538#note_1726593364

>               },
>       };
>  
> -     int n_urls = countof(urls);
>       // functions won't come back if an error occurs
>       wget_test_start_server(
> -             WGET_TEST_RESPONSE_URLS, &urls, n_urls,
> +             WGET_TEST_RESPONSE_URLS, &urls, countof(urls),
>               WGET_TEST_FEATURE_MHD,
>               0);
>  
> +     int n_urls = countof(urls);

Ah, but on the Linux box too `sizeof(size_t)` is being reported as `8` > `4` 
(sizeof(int)).

But on M2, garbage `nurls` value get accessed by `va_arg()`. Perhaps on Linux 
the adjacent 4 bytes are `0`.

-- 
Reply to this email directly or view it on GitLab: 
https://gitlab.com/gnuwget/wget2/-/merge_requests/538#note_1726593364
You're receiving this email because of your account on gitlab.com.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]