Re: [XBoard-devel] HtmlHelp() argument 4

[Tim Mann]

Changing DWORD to DWORD_PTR is not 64-bit clean.  (I'm not sure if
WinBoard is 64-bit clean in general, but xboard is unless someone has
broken it since 4.2.7.)

According to msdn.microsoft.com, DWORD is always 32 bits, even in a
64-bit model, while DWORD_PTR is an unsigned integer type that is the
same width as a pointer -- like the Posix uintptr_t type.

If DWORD_PTR isn't defined in your headers, "unsigned long" should work
in a pinch, assuming that MS compilers make "long" a 64-bit type when
compiling for 64-bit machines and 32-bit for 32-bit machines.

        --Tim

On Sat, 11 Jul 2009 20:19:55 -0600, Eric Mullins <address@hidden> wrote:
> Aside from warnings, one reason for my patch was to allow this to 
> compile in MSVC 6.x and 4.1.
> 
> The type *DWORD_PTR* doesn't exist in those headers.  I changed it to 
> DWORD and passed 0 instead of NULL in the calls in order to fix that 
> problem.
> 
> -int
> -HtmlHelp( HWND hwnd, LPCSTR helpFile, UINT action, DWORD data )
> +HWND WINAPI
> +HtmlHelp( HWND hwnd, LPCSTR helpFile, UINT action, DWORD_PTR data )
> 
> 
> author        H.G. Muller <address@hidden>    2009-07-12 01:19:30 (GMT)
> committer     Arun Persaud <address@hidden>   2009-07-12 01:19:30 (GMT)
> commit        3cc03b735ac2bff48a80937827a2ddcf22878959 
> <http://git.savannah.gnu.org/cgit/xboard.git/commit/?id=3cc03b735ac2bff48a80937827a2ddcf22878959>
>  
> (patch 
> <http://git.savannah.gnu.org/cgit/xboard.git/patch/?id=3cc03b735ac2bff48a80937827a2ddcf22878959>)
>  
> 
> tree  dfc24a76d5e01b8ba6664c8d8e1ff96fea52d138 
> <http://git.savannah.gnu.org/cgit/xboard.git/tree/?id=3cc03b735ac2bff48a80937827a2ddcf22878959>
>  
> 
> parent        09d3d08d9ce11ff482e34bad7b97380f134c14f4 
> <http://git.savannah.gnu.org/cgit/xboard.git/commit/?id=09d3d08d9ce11ff482e34bad7b97380f134c14f4>
>  
> (diff 
> <http://git.savannah.gnu.org/cgit/xboard.git/diff/?id=3cc03b735ac2bff48a80937827a2ddcf22878959&id2=09d3d08d9ce11ff482e34bad7b97380f134c14f4>)
>  
> 
> download      xboard-3cc03b735ac2bff48a80937827a2ddcf22878959.tar.gz 
> <http://git.savannah.gnu.org/cgit/xboard.git/snapshot/xboard-3cc03b735ac2bff48a80937827a2ddcf22878959.tar.gz>
>  
> 
> 


-- 
Tim Mann  address@hidden  http://tim-mann.org/