[XBoard-devel] PATCH [PULL-REQUEST]: Modernise function prototypes

[Thomas Adam]

Hi,

The following changes since commit 34b24704e5f5af21466a1aae06b9135b1e001b90:

  remove OS X theme folder (2014-10-24 22:27:31 -0700)

are available in the git repository at:

  https://github.com/ThomasAdam/xboard.git ta/tidy-prototypes

for you to fetch changes up to 095bf778fc51e2662406b80c700f175e3a1ae17b:

  winboard/wsettings: Modernise function prototypes (2015-03-24 19:56:55 +0000)


This is step one in my attempt to start cleaning up the code slightly.
There should be no functional changes whatsoever, and the changes are to
remove the P() macro and add things like missing 'void' to function
protoypes, etc.

I've chunked these changes into separate files to try to make them
easier to review, although I've only been able to give the winboard
changes a cursory check as I cannot compile that.

I note that Savannah is still not up to date with HGM's changes; that's
OK, and if people are happy with the sorts of changes I've done, I can
always update that moving forward.  It's always difficult to get
complete coverage to changes like this as code is a moving target
anyway.

The diffstat is below.  Any questions, or comments, do please ask.

----------------------------------------------------------------
Thomas Adam (47):
      backend:  Modernise function prototypes
      args:  Modernise function prototypes
      backendz:  Modernise function prototypes
      board:  Modernise function prototypes
      book:  Modernise function prototypes
      childio:  Modernise function prototypes
      common:  Modernise function prototypes
      dialogs:  Modernise function prototypes
      draw:  Modernise function prototypes
      engineoutput:  Modernise function prototypes
      evalgraph:  Modernise function prototypes
      frontend:  Modernise function prototypes
      gamelist:  Modernise function prototypes
      history:  Modernise function prototypes
      lists:  Modernise function prototypes
      menus:  Modernise function prototypes
      moves:  Modernise function prototypes
      nengineoutput:  Modernise function prototypes
      nevalgraph:  Modernise function prototypes
      ngamelist:  Modernise function prototypes
      nhistory:  Modernise function prototypes
      parser:  Modernise function prototypes
      pgntags:  Modernise function prototypes
      uci:  Modernise function prototypes
      usounds:  Modernise function prototypes
      usystem:  Modernise function prototypes
      xboard2:  Modernise function prototypes
      zippy:  Modernise function prototypes
      gtk/xboard:  Modernise function prototypes
      gtk/xengineoutput:  Modernise function prototypes
      gtk/xoptions:  Modernise function prototypes
      gtk/xtimer:  Modernise function prototypes
      xaw/xboard:  Modernise function prototypes
      xaw/xengineoutput:  Modernise function prototypes
      xaw/xgamelist:  Modernise function prototypes
      xaw/xhistory:  Modernise function prototypes
      xaw/xoptions:  Modernise function prototypes
      winboard/jaws:  Modernise function prototypes
      winboard/wchat:  Modernise function prototypes
      winboard/wclipbrd:  Modernise function prototypes
      winboard/wedittags:  Modernise function prototypes
      winboard/wengineoutput: Modernise function prototypes
      winboard/wevalgraph: Modernise function prototypes
      winboard/wgamelist; Modernise function prototypes
      winboard/whistory:  Modernise function prototypes
      winboard/winboard: Modernise function prototypes
      winboard/wsettings: Modernise function prototypes

 args.h                   |  50 +--
 backend.c                | 785 +++++++++++++++++++++++------------------------
 backend.h                | 363 +++++++++++-----------
 backendz.h               |  13 +-
 board.c                  |  84 ++---
 board.h                  |  32 +-
 book.c                   |  52 ++--
 childio.c                |  14 +-
 childio.h                |   2 +-
 common.h                 |   6 +-
 dialogs.c                | 372 +++++++++++-----------
 dialogs.h                | 140 ++++-----
 draw.c                   |  72 ++---
 draw.h                   |  26 +-
 engineoutput.c           |  26 +-
 engineoutput.h           |  22 +-
 evalgraph.c              |  30 +-
 evalgraph.h              |  14 +-
 frontend.h               | 295 +++++++++---------
 gamelist.c               |  40 +--
 gtk/xboard.c             | 213 ++++++-------
 gtk/xboard.h             |  30 +-
 gtk/xengineoutput.c      |  12 +-
 gtk/xoptions.c           |  99 +++---
 gtk/xtimer.c             |  22 +-
 history.c                |  30 +-
 lists.c                  |  18 +-
 lists.h                  |  18 +-
 menus.c                  | 156 +++++-----
 menus.h                  | 207 +++++++------
 moves.c                  | 138 ++++-----
 moves.h                  |  41 +--
 nengineoutput.c          |  20 +-
 nevalgraph.c             |  22 +-
 ngamelist.c              |  34 +-
 nhistory.c               |  22 +-
 parser.c                 |  34 +-
 parser.h                 |  10 +-
 pgntags.c                |  10 +-
 uci.c                    |   4 +-
 usounds.c                |  22 +-
 usystem.c                |  60 ++--
 usystem.h                |   8 +-
 winboard/jaws.c          |  53 ++--
 winboard/wchat.c         |  14 +-
 winboard/wclipbrd.c      |  16 +-
 winboard/wedittags.c     |   2 +-
 winboard/wengineoutput.c |  12 +-
 winboard/wevalgraph.c    |   6 +-
 winboard/wgamelist.c     |   8 +-
 winboard/whistory.c      |  16 +-
 winboard/winboard.c      |  44 +--
 winboard/wsettings.c     |  22 +-
 xaw/xboard.c             | 278 +++++++++--------
 xaw/xboard.h             |  32 +-
 xaw/xengineoutput.c      |  26 +-
 xaw/xgamelist.c          |   6 +-
 xaw/xgamelist.h          |   6 +-
 xaw/xhistory.c           |  10 +-
 xaw/xhistory.h           |   6 +-
 xaw/xoptions.c           | 104 +++----
 xboard2.h                |   6 +-
 zippy.c                  |  30 +-
 zippy.h                  |  17 +-
 64 files changed, 2155 insertions(+), 2227 deletions(-)

-- Thomas Adam

-- 
"Deep in my heart I wish I was wrong.  But deep in my heart I know I am
not." -- Morrissey ("Girl Least Likely To" -- off of Viva Hate.)