Re: [XWEM]: [PATCH] Couple of minor fixes for weather and time

[Zajcev Evgeny]

Steve Youngs <address@hidden> writes:

> Here are those patches...
>
> --- 
> /home/steve/programming/XEmacs/packages/xemacs-packages/xwem/dockapp/xwem-time.el
>  2004-11-18 10:51:40.000000000 +1000
> +++ /usr/local/lib/xemacs/xemacs-packages/lisp/xwem/xwem-time.el      
> 2004-11-27 00:49:46.000000000 +1000
> @@ -33,8 +33,7 @@
>  ;;
>  ;; To start using it, add:
>  ;;
> -;;    (autoload 'xwem-time "xwem-time" "Start `display-time' like app in 
> system tray.")
> -;;    (add-hook 'xwem-after-init-hook 'xwem-time)
> +;;    (require 'xwem-time)
>  ;;
>  ;; to your xwemrc.
>  
> @@ -58,6 +57,21 @@
>    :prefix "xwem-time-"
>    :group 'xwem)
>  
> +(defcustom xwem-time-auto-start t
> +  "*Non-nil start xwem-time dockapp automatically.
> +
> +If non-nil user set up is done by adding the following to
> +~/.xwem/xwemrc.el...
> +  
> +  \(require 'xwem-time\)
> +
> +If nil, user set up is done by adding the following to 
> +~/.xwem/xwemrc.el...
> +
> +  \(add-hook 'xwem-after-init-hook 'xwem-time\)"
> +  :type 'boolean
> +  :group 'xwem-time)
> +
>  (defcustom xwem-time-display-time t
>    "*Non-nil mean display current time."
>    :type 'boolean
> @@ -1297,7 +1311,8 @@
>  
>  ;;;; On-load actions:
>  ;; - Start time dockapp
> -(if xwem-started
> +(if (and xwem-started
> +      xwem-time-auto-start)
>      (xwem-time)
>    (add-hook 'xwem-after-init-hook 'xwem-time))

Maybe just move 

   `(setq xwem-started t)' in xwem-main.el just after
xwem-after-init-hooks are done?

so xwem-time-auto-start variable became unneeded

>  
>
> --- 
> /home/steve/programming/XEmacs/packages/xemacs-packages/xwem/dockapp/xwem-weather.el
>       2004-11-22 19:56:12.000000000 +1000
> +++ /usr/local/lib/xemacs/xemacs-packages/lisp/xwem/xwem-weather.el   
> 2004-11-26 23:59:35.000000000 +1000
> @@ -163,7 +163,7 @@
>    (let* ((host xwem-weather-url-fqdn)
>           (dir xwem-weather-url-dir)
>           (file (upcase (concat xwem-weather-station-id ".txt")))
> -         (path (expand-file-name file dir))
> +         (path (concat dir "/" file))
>           (user-agent (concat "XEmacs " emacs-program-version))
>           (http (open-network-stream "xwem-weather-update"
>                                      " *xwem-weather-update-buf*"
>

Yeah i already noticed this issue :)

> Let me know if you want me to explain any of that.

-- 
lg