bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#70345: [PATCH] 29.1.50; csharp-ts-mode indentation of if statements


From: john muhl
Subject: bug#70345: [PATCH] 29.1.50; csharp-ts-mode indentation of if statements with single-statement body
Date: Sat, 27 Apr 2024 08:10:47 -0500
User-agent: mu4e 1.10.8; emacs 30.0.50

Eli Zaretskii <eliz@gnu.org> writes:

>> Cc: 70345@debbugs.gnu.org, Jacob Leeming <jacobtophatleeming@gmail.com>
>> From: Jacob Leeming <jacobtophatleeming@gmail.com>
>> Date: Mon, 22 Apr 2024 09:50:23 +0100
>> 
>> > Looks good to me. Are you willing to pack this up with a nice test
>> > confirming the behavior?
>> >
>> > All the best,
>> > Theo
>> 
>> Thanks all,
>> 
>> Discovered we had a similar issue for else blocks. Wrote a test that
>> covers both cases.
>> 
>> See the attached diff which contains my changes to the indent rules and
>> the test.
>
> Thanks, I installed this on the emacs-29 branch.  (The test you added
> should have been added to csharp-mode-tests.el, since our test files
> follow the names of the implementation files, and csharp-ts-mode is
> implemented in csharp-mode.el.  I fixed that.)

The test should check that the c-sharp grammar is available so
that it gets marked as skipped instead of failed.

Attachment: 0001-Skip-csharp-ts-mode-test-if-grammar-is-missing.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]