Re: [bug-gnubatch] Compiler warnings (as of 1.6 rel)

[John Collins (Xi Software Ltd)]

On 08/09/12 23:52, Jan Schampera wrote:

Here some compiler warnings, no patches since I'm not sure at all.


parsehtab.c: In function ‘gsn_getloc’:
parsehtab.c:170: warning: pointer targets in passing argument 3 of ‘getsockname’ differ in signedness
/usr/include/sys/socket.h:119: note: expected ‘socklen_t * __restrict__’ but argument is of type ‘int *’
--> blindly use socklen_t?

The trouble about doing that is that it falls over on some platforms. If someone can suggest a better check in the configure.ac script I'll change it.

Linus has some strong comments about the confusion with versions!

btcharge.c:35: warning: ‘Filename’ defined but not used
--> Might be about (not) using ABORT_NOMEM, which is true in some other places, too (which just are not compiled, I guess).

Oh yes the should come out. It doesn't use anything which allocates memory any more. Likewise other things.

y.tab.c: In function ‘yyparse’:
y.tab.c:1392: warning: implicit declaration of function ‘yylex’
--> predeclare yylex in the atcover parser generator?

That's a quirk-ette of yacc/bison libraries I think.

gbatch_jobdata.c: In function ‘gbatch_jobdata’:
gbatch_jobdata.c:115: warning: implicit declaration of function ‘sigset’
--> probably something wrong with HAVE_SIGSET?

That's me being lazy about setting up ignoring signals in a portable way. I think that sigset should be defined in signal.h if the library supports it.

--
John Collins address@hidden Xi Software Ltd www.xisl.com

Phone: +44 (0)1707 886110 Home Phone: +44 (0)1707 883174
Mobile: +44 (0)7958 387247 (address@hidden)

Trading Address 3 Mandeville Rise, Welwyn Garden City, Herts, AL8 7JT, UK

Registered in England Company Number 01977148 VAT GB 403 9239 64 R/O: 2 Mill Road, Haverhill, Suffolk, CB9 8BD