Re: [Bug-mcron] [PATCHES] Fix various build issues.

[Dale Mellor]

On Mon, 2015-07-06 at 14:20 +0200, Mathieu Lirzin wrote:
> Dale Mellor <address@hidden> writes:
> 
> > Thank you very much.  Commits pushed to Savannah.  A new formal release
> > will be happening in the next couple of months.
> 
> I would have prefer that you reviewed my patches and ask for changes
> before messing them up by silently rewriting and pushing them with
> commit mistakes under my name.  Despite your thanks, I find this not
> very welcoming.
> 
> Apparently we have a different opinion on capitalization of "makefiles"
> file names, and a different interpretation of the GNU change logs style.
> You should have raised theses issues instead of nodding and pushing
> something else.  As a GNU maintainer you should take look at
> (info "(maintain) Clean Ups") for good practices about how to deal with
> such issues.
> 
> I intend to keep contributing to Mcron, so I hope we will overcome this
> misunderstanding.
> 
> --
> Mathieu Lirzin
> 

1) I pushed three out of four of your patches verbatim, interspersed
with some changes I felt I wanted to make.  It is all documented within
the repository (and this mail thread).

2) The other patch (0003-...) I didn't apply because
   1) It wouldn't apply with `git am',
   2) I didn't agree with it.

3) Capitalising `makefile' makes no difference to the quality of the
project, and I much prefer lower case.

4) Comments along the lines of `Makefile.ed: likewise' strike me as
worse than useless.  I prefer log files which explain changes in english
prose.

5) The reference you gave me regarding being a GNU maintainer I feel
reinforces my actions.  Please consider the possibility that you are
being over-sensitive (we are only disagreeing over the capitalization of
a letter!)

6) I really do value the contribution that you have made to my project
(I will give you credit when I make the next formal release), and am
always willing to hear constructive criticism.


Best wishes,
Dale

signature.asc
Description: This is a digitally signed message part