Re: [CASHeW-s-editor-patches] I am commiting changes to support consistent behavour (starting from max always) of editor.......

[R Bhagdev]

Thanks for pointing out Andrew, I will change and make sure it uses factory.  I
don't know why it replaced the whole file.  What can be wrong?

- Ravish.

Quoting Andrew John Hughes <address@hidden>:

> On Thu, 2005-03-31 at 03:43 +0100, Ravish Bhagdev wrote:
> > I am comming the attached patch to allow only nodes with maximum number
> from the nodes always, as Barry suggested in last meeting.  Three model files
> are modified as mentioned below (patch attached):
> > 
> > Changelog:
> > 
> > 2005-03-31  Ravish Bhagdev  address@hidden
> > 
> > * src/nongnu/cashews/eclipse/model/Connection.java
> > * src/nongnu/cashews/eclipse/model/DiagramParser.java
> > * src/nongnu/cashews/eclipse/model/NodeRegistrar.java
> > 
> > - getSource() method added in Connection class
> > - Parser modified to remove a bug causing repetition of outgoing edges in
> model.
> > - Added private int max property in NodeRegistrar along with getter and
> setter methods for the same.  
> > 
> > - Ravish.
> > _______________________________________________
> > CASHeW-s-editor-patches mailing list
> > address@hidden
> > http://lists.nongnu.org/mailman/listinfo/cashew-s-editor-patches
> > 
> > 
> > 
> > 
> >
>
--------------------------------------------------------------------------------
> > 
> > 
> > _______________________________________________
> > CASHeW-s-editor-patches mailing list
> > address@hidden
> > http://lists.nongnu.org/mailman/listinfo/cashew-s-editor-patches
> > _______________________________________________
> > CASHeW-s-editor-patches mailing list
> > address@hidden
> > http://lists.nongnu.org/mailman/listinfo/cashew-s-editor-patches
> 
> I don't get why you create the Nodes manually in the Parser, rather than
> using the factory, which already has a method for capturing the node
> number.  It seems we have duplicate functionality here.
> 
> Also, I don't know what went wrong with the patch, but it seems to
> replace the entire parser, even though not all of it has changed.
> -- 
> Andrew :-)
> 
> Please avoid sending me Microsoft Office (e.g. Word, PowerPoint)
> attachments.
> See http://www.fsf.org/philosophy/no-word-attachments.html
> 
> No software patents in Europe -- http://nosoftwarepatents.com
> 
> "Value your freedom, or you will lose it, teaches history.
> `Don't bother us with politics' respond those who don't want to learn."
> -- Richard Stallman
> 
> Escape the Java Trap with GNU Classpath!
> http://www.gnu.org/philosophy/java-trap.html
> public class gcj extends Freedom implements Java { ... }
> 
>