Re: [PATCH] allow overriding value/syntax toplevel bindings (#1166)

[felix . winkelmann]

> On Sun, Nov 12, 2023 at 01:45:06PM +0100, felix.winkelmann@bevuta.com wrote:
> > See commit message.
> 
> Nice to make some progress on this!
> 
> However, I tested the example given in the ticket:
> 
>  (define begin -)
>  (begin 0 1) => 1  ;; expected: -1
> 
> This still evaluates to 1.
> 

Yes, this is admittedly all a bit ugly. Please find attached 2 patches:
the first addresses the endless expansion loop caused by our recent change
in ##sys#canonicalize-body. The second patch is a new version of the "override"
patch, with some additional changes to address the example above and a
followup problem that came up during testing.

I post the two patches together, because the latter includes the change for
the former. Please apply at least the former, if you still have doubts about
the override changes.


felix

0001-Fix-hygienic-comparison-for-begin-forms-when-expandi.patch
Description: Text document

0001-Retain-current-identifier-status-as-syntax-or-value-.patch
Description: Text document