Re: MPS: face-cache

[Gerd Möllmann]

Gerd Möllmann <gerd.moellmann@gmail.com> writes:

> FYI: Just found this while randomly debugging
>
>   static uintptr_t
>   lface_hash (Lisp_Object *v)
>   {
>     return (hash_string_case_insensitive (v[LFACE_FAMILY_INDEX])
>             ^ hash_string_case_insensitive (v[LFACE_FOUNDRY_INDEX])
>             ^ hash_string_case_insensitive (v[LFACE_FOREGROUND_INDEX])
>             ^ hash_string_case_insensitive (v[LFACE_BACKGROUND_INDEX])
>             ^ XHASH (v[LFACE_WEIGHT_INDEX])
>             ^ XHASH (v[LFACE_SLANT_INDEX])
>             ^ XHASH (v[LFACE_SWIDTH_INDEX])
>             ^ XHASH (v[LFACE_HEIGHT_INDEX]));
>   }
>
> XHASH is address dependent, so it can't work. That should be igc_hash
> for MPS.
>
> Not today, though. Good night!

Moin moin.

Did that now, but it's still crashing. My impression, which might of
course be completely wrong, is that we are losing faces somehow, i.e.
something is wrong with the cache.