Re: [Fenfire-dev] Libvob: Modifications in base classes.

[Benja Fallenstein]

Hi,

sorry for not responding earlier.

Matti Katila wrote:
> I finally implemented the animation_api--mudyc since I felt it was time 
> for it. The change modifies some "frozen" packages (currently there are no 
> any frozen packages acording to documentation).

Yeah, we need some process to make sure that PEGs don't just lie around, 
but are actually processed etc. How about: On our formal meetings each 
week, we have a look at the list of pending PEGs and decide what to do 
about them?

We should probably send minutes of these meetings to the public list, 
especially if we talk about the PEGs there. (It should be easy for other 
developers to join in without feeling that all the important discussions 
happen off-list.)

Also there's the question how Fenfire, Libvob etc. PEGs should be 
decided now that Tuomas doesn't maintain these packages any more. Maybe 
rough consensus is good enough as a decision tool.

About this PEG, I agree it should be implemented. We should at some 
point go through it together to fix grammar &c, though (because it's 
important documentation). Not before the article dl, tho.

> I list the differenties here so you can comment on:
>
> --- orig/org/nongnu/libvob/Shower.java
> +++ mod/org/nongnu/libvob/Shower.java
> @@ -35,6 +35,6 @@
>      /** Generate a new VobScene, corresponding to the current 
>       * state of the matters.
>       */
> -    VobScene generate();
> -    void setScreen(Screen s) ;
> +    VobScene generate(WindowAnimation anim);
> +    void setScreen(Screen s);
>  }

Ok.

> Well, I would like to change this to 
>
>     VobScene generate(VobScene emptyVS);

What does the emptyVS mean?

> --- orig/org/nongnu/libvob/VobScene.java
> +++ mod/org/nongnu/libvob/VobScene.java
> @@ -137,6 +137,8 @@
>      public final VobCoorder coords;
>      public final VobMatcher matcher;
>  
> +    public WindowAnimation anim = null;
> +
>      public final GraphicsAPI gfxapi;
>      public final GraphicsAPI.RenderingSurface window;

I don't like this, why not

    public final WindowAnimation anim;

and set it in the constructor?

> The basic idea is an enhacement in VobScene, e.g.,
>
> vs.anim.animate()
> vs.anim.rerender()

That seems ok.

- Benja