findutils-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Findutils-patches] [PATCH] find -prune now makes sure it has valid stat


From: Colin Watson
Subject: [Findutils-patches] [PATCH] find -prune now makes sure it has valid stat() information
Date: Thu, 7 May 2009 22:14:19 +0100
User-agent: Mutt/1.5.18 (2008-05-17)

The original problem that led me to find this bug was reported here:

  https://bugs.launchpad.net/ubuntu/+source/findutils/+bug/373214

... and amounts to "/usr/include/asm/ contents missing from Linux kernel
package when built with findutils 4.4.1".


The -prune action needs stat information when -depth is not given, but
find's parser fails to declare this. It is therefore possible for -prune
to use undefined stat data.

I've attached a patch (against the rel-4-4-fixes branch, I'm afraid; I
have spent the whole afternoon trying to track this down in the face of
half our developers complaining because all their builds are breaking,
so I'd rather do something else right now, but I wanted to get this
patch sent; if you need it reconstructed against master then I can do
that tomorrow), including a test that you may be able to get to
demonstrate the problem. Whether the test actually fails for you is
unfortunately not certain, since it's an undefined-data problem; you
should at least be able to see the bug manually by breaking on
pred_prune.

Thanks,

-- 
Colin Watson                                       address@hidden

Attachment: 0001-find-prune-now-makes-sure-it-has-valid-stat-infor.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]