[Findutils-patches] bootstrapping [was: xattr and capability support]

[Eric Blake]

[re-adding the list for this portion of the conversation]

On 11/06/2014 10:45 AM, KillBoy PowerHed wrote:
> Sent .. I've attached output from git clone etc my machine, would you mind 
> comparing with yours?

> Odd; I'm also using Fedora 20, with the same version of gettext, but
> running ./import-gnulib.sh on a fresh checkout of findutils.git did not
> fail for me (although it was a bit noisy; I have an action item that to
> try and reduce some of the noise when I get some free time).

[also, top-posting makes for very awkward reading on technical lists]

> address@hidden Downloads]$ git clone git://git.sv.gnu.org/findutils

> address@hidden Downloads]$ cd findutils
> address@hidden findutils]$ ./import-gnulib.sh 
> Checking the submodule directory layout... 
> You have a ./gnulib directory which does not appear to be a submodule.

Ouch.  We really ought to fix ./import-gnulib.sh to not balk about a
completely empty ./gnulib directory placeholder (it should only balk
when there are contents in the directory); a fresh git clone need not
worry about overwriting an empty directory.

Or, as has been mentioned in other threads, if we convert findutils over
to using the same bootstrap as coreutils is using, that issue would go
away...

> address@hidden findutils]$ rm -rf gnulib

Or the slightly safer 'rmdir gnulib', for a fresh checkout :)

> address@hidden findutils]$ ./import-gnulib.sh 
> Checking the submodule directory layout... 
> The submodule directory layout looks OK.
> Submodule 'gnulib' (git://git.sv.gnu.org/gnulib.git) registered for path 
> 'gnulib'
> Cloning into 'gnulib'...
> remote: Counting objects: 154562, done.
> remote: Compressing objects: 100% (23748/23748), done.

Ugg - we aren't honoring $GNULIB_SRCDIR like other GNU projects, which
results in a lot more bandwidth to download all of gnulib instead of
sharing objects with an already-existing local copy (not that everyone
has GNULIB_SRCDIR set, but when it is set, it makes a difference).
Again, something that would be fixed by modernizing to coreutils' bootstrap.

...
> Don't forget to
>   - add "gl/lib/Makefile" to AC_CONFIG_FILES in ./configure.ac,
>   - add "tests/Makefile" to AC_CONFIG_FILES in ./configure.ac,
>   - mention "lib" in SUBDIRS in gl/Makefile.am,
>   - mention "tests" in SUBDIRS in Makefile.am,
>   - mention "-I gl/m4" in ACLOCAL_AMFLAGS in Makefile.am,
>   - mention "gl/m4/gnulib-cache.m4" in EXTRA_DIST in Makefile.am,
>   - invoke gl_EARLY in ./configure.ac, right after AC_PROG_CC,
>   - invoke gl_INIT in ./configure.ac.
> + set +x
> Updating the license of build-aux/config.guess... no change needed.
> Updating the license of build-aux/config.sub... no change needed.
> Updating the license of build-aux/depcomp... done.
> Updating the license of build-aux/install-sh... no change needed.
> Updating the license of doc/mdate-sh... done.
> Updating the license of build-aux/mkinstalldirs... no change needed.
> Updating the license of doc/texinfo.tex... no change needed.
> autopoint: *** Missing version: please specify in configure.ac through a line 
> 'AM_GNU_GETTEXT_VERSION(x.yy.zz)' the gettext version the package is using
> autopoint: *** Stop.
> FAILED
> 

at this point, my output on Fedora 20 was:

  - invoke gl_INIT in ./configure.ac.
+ set +x
Updating the license of build-aux/config.guess... no change needed.
Updating the license of build-aux/config.sub... no change needed.
Updating the license of build-aux/depcomp... done.
Updating the license of build-aux/install-sh... no change needed.
Updating the license of doc/mdate-sh... done.
Updating the license of build-aux/mkinstalldirs... no change needed.
Updating the license of doc/texinfo.tex... no change needed.
Copying file ABOUT-NLS
Copying file build-aux/config.rpath
Copying file po/Makefile.in.in
configure.ac:87: warning: AC_REQUIRE: `gl_HEADER_SYS_SOCKET' was
expanded before it was required
configure.ac:87:
http://www.gnu.org/software/autoconf/manual/autoconf.html#Expanded-Before-Required
...

I'm still not sure why it's working for me but not for you.  But the
noise I'm seeing is something that needs to be cleaned up in gnulib...

$ rpm -qf `which autopoint`
gettext-devel-0.18.3.2-2.fc20.x86_64
$ git describe
v4.5.14-15-g67dbfc9
$ git submodule foreach git describe
Entering 'gnulib'
v0.1-126-g94ee038

Hmm - your error message is produced by 'autopoint', not by
./import-gnulib.sh (well, it is occurring at the point in
import-gnulib.sh that calls the refresh_output_files function to shell
out to autopoint -f).  I wonder if you are missing a weak prerequisite
of gettext, such that your build of autopoint is failing to parse
configure.ac but where I have more packages and therefore no problem in
parsing it.  Can you show:

sh -x /usr/bin/autopoint -f

to see if that highlights the difference in our environments?

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature