Re: [Findutils-patches] [PATCH] Add a -sort option to use fts's sorted traversal functionality

[Eric Blake]

On 12/29/2014 04:49 PM, Phil Miller wrote:
> * find/defs.h (struct options): Add a 'sort' flag.

A boolean flag is insufficient.  The default should remain unsorted, but
you should offer the ability to sort by either name or inode, which
means -sort needs to take an argument to say which sorting method to use.


> ---
> I don't know if this is considered trivial enough to not require explicit
> copyright assignment. If it isn't, then I'll be happy to go through that
> process.
> 
>  find/defs.h    |  3 +++
>  find/find.1    |  9 +++++++++
>  find/ftsfind.c |  8 ++++++--
>  find/parser.c  | 12 ++++++++++++
>  find/util.c    |  1 +
>  5 files changed, 31 insertions(+), 2 deletions(-)

Code-wise, it might be trivial, but by the time you add documentation, a
NEWS entry, and testsuite coverage of the new feature, it will be
non-trivial, so yes, you should pursue the copyright assignment process.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature