Re: [Freeipmi-devel] Using libfreeipmi interface

[Ian Zimmerman]

Andrew> I also found a problem with the IPMI_LAN_SEQ_NUM_MAX (=0x3F).
Andrew> There isn't any precedent in IPMI 1.5 for this, and limiting the
Andrew> 32- bitsequence number to 6 bits causes some problems, since the
Andrew> BMC LAN won't handle wrapping the sequence number back to 0 or 1
Andrew> after 63 (0x3f).

Al> I'm not quite convinced this is a problem.  The bounds check makes
Al> the user knowledgeable to the fact that arbitrary sequence numbers
Al> aren't allowed.  I spoke to a few other developers I work with, and
Al> they feel that the bounds checking is more appropriate.  Ab, Ian,
Al> Bala, what are your thoughts??

Ian> Hmm, where is the sequence number field specified?  The closest I
Ian> see is Figure 12-4 which is unfortunately quite unclear (to me at
Ian> least).  It doesn't say how many bits are taken by the LUN and how
Ian> many by Rqseq.  How have we come by tmpl_lan_msg_hdr_r[sq] - by
Ian> experiment?

Sorry for replying to myself :-)  Regardless of the spec, just the fact
that the number is going to be stuffed into a 6 bit field justifies the
check, IMHO.