freeipmi-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Freeipmi-devel] "Enable_User" option in bmc-config --checkout


From: Bala.A
Subject: Re: [Freeipmi-devel] "Enable_User" option in bmc-config --checkout
Date: Fri, 3 Dec 2004 18:57:43 -0800 (PST)
User-agent: SquirrelMail/1.4.0

Hi Al,

The patch is 100% perfect.

But I made two changes for consistency.  I removed
(get-enable-user-string) in bc-common.scm and I use get-string instead of
get-enable-user-string in user-keys-validator.

Thanks,

Best Regards
Bala

> Hey AB, Bala,
>
> Here is a proposed patch.  Can you please look it over real quick?  I'd
> like to get this problem resolved soon.
>
> ====
> Index: fish/extensions/bc-common.scm
> ===================================================================
> RCS file: /cvsroot/freeipmi/freeipmi/fish/extensions/bc-common.scm,v
> retrieving revision 1.8
> diff -r1.8 bc-common.scm
> 178a179,180
>> (define (get-enable-user-string str) "")
>>
> Index: fish/extensions/bc-user-section.scm
> ===================================================================
> RCS file: /cvsroot/freeipmi/freeipmi/fish/extensions/bc-user-section.scm,v
> retrieving revision 1.6
> diff -r1.6 bc-user-section.scm
> 38c38,42
> < (define (checkout-enable-user section-name) #f)
> ---
>> ; achu: Can't checkout
>> (define (checkout-enable-user section-name) (list ""))
>>
>> ; achu: Can't check, just assume its ok??
>> (define (diff-enable-user section-name user-enable-user
> bmc-enable-user) #t)
> 325,327c329,331
> <      get-boolean-string
> <      same-string?
> <      "Possible values: Yes/No")
> ---
>>      get-enable-user-string
>>      diff-enable-user
>>      "Possible values: Yes/No or blank to not set")
> Index: fish/extensions/bc2.scm
> ===================================================================
> RCS file: /cvsroot/freeipmi/freeipmi/fish/extensions/bc2.scm,v
> retrieving revision 1.3
> diff -r1.3 bc2.scm
> 36c36
> < ;               "Enable_User"
> ---
>>                 "Enable_User"
> 52c52
> < ;               "Enable_User"
> ---
>>                 "Enable_User"
> 68c68
> < ;               "Enable_User"
> ---
>>                 "Enable_User"
> 84c84
> < ;               "Enable_User"
> ---
>>                 "Enable_User"
> ====
>
> Al
>
> --
> Albert Chu
> address@hidden
> Lawrence Livermore National Laboratory
>
> ----- Original Message -----
> From: Albert Chu <address@hidden>
> Date: Friday, December 3, 2004 12:34 pm
> Subject: Re: [Freeipmi-devel] "Enable_User" option in bmc-config
> --checkout
>
>> Oh, and it just occurred to me that it may not be possible to output
>> whether a user is enabled or not, just like the password.
>>
>> In that case, the value of "Enable_User" could be blank, Yes, or
>> No.  A
>> blank value on --commit simply means don't change anything.
>>
>> Al
>>
>> --
>> Albert Chu
>> address@hidden
>> Lawrence Livermore National Laboratory
>>
>> ----- Original Message -----
>> From: Albert Chu <address@hidden>
>> Date: Friday, December 3, 2004 12:29 pm
>> Subject: [Freeipmi-devel] "Enable_User" option in bmc-config --
>> checkout
>> > I believe most users will run bmc-config --checkout to grab a
>> current> configuration, edit the configuration, then pump it back
>> into bmc-
>> > commit--commit to configuration a BMC.
>> >
>> > Thus, I think it would be a good idea to have --checkout output the
>> > "Enable_User" configuration option for each user.
>> >
>> > Al
>> >
>> > --
>> > Albert Chu
>> > address@hidden
>> > Lawrence Livermore National Laboratory
>> >
>> >
>> >
>> > _______________________________________________
>> > Freeipmi-devel mailing list
>> > address@hidden
>> > http://lists.gnu.org/mailman/listinfo/freeipmi-devel
>> >
>>
>>
>
>
>
> _______________________________________________
> Freeipmi-devel mailing list
> address@hidden
> http://lists.gnu.org/mailman/listinfo/freeipmi-devel
>
>


-- 
Free as in Freedom
http://www.gnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]