Re: [Freeipmi-devel] Bug in ipmi-sel

[tom zimmerman]

Al Chu wrote:

> Hey Tom,
>
> After skimming through the code real quick, I realized the fixes only
> had to go to 1 tiny section of code.  I applied the fixes into the CVS
> head.  Do you think you could check it out real quick?
>
>  
Al,

Yes,  That fixed it.

Thanks,  Tom Zimmerman

> Effectively, the bug came down to the fact that on your motherboard, the
> SDR timestamps are set to UINT_MAX for some reason.
>
> most_recent_addition_timestamp=4294967295
> most_recent_erase_timestamp=4294967295
>
> The code read this field as an int instead of a uint and got confused
> b/c INT_MAX = 2.1 billion < 4.2 billion = UINT_MAX.
>
> Thanks for the catch.
>
> Al
>
> On Mon, 2007-06-25 at 10:32 -0700, Al Chu wrote:
>  
>
> > Hey Tom,
> >
> > Thanks for the sdr cache.  I figured out the problem.  It has to do with
> > some signed vs. unsigned integers.  I need to do some code reviewing to
> > figure out where else the fixes need to go, so gimme a day or two.
> >
> > Thanks,
> > Al
> >
> > On Mon, 2007-06-25 at 10:42 -0600, tom zimmerman wrote:
> >    
> >
> > > Al Chu wrote:
> > >
> > >      
> > >
> > > > Hey Tom,
> > > >
> > > > On Fri, 2007-06-22 at 11:22 -0600, tom zimmerman wrote:
> > > >
> > > >
> > > >        
> > > >
> > > > > I am getting the following error in listing the system event logs.
> > > > >
> > > > > /ipmi-sel/src/ipmi-sel -D LAN -h bmc1 -u admin -p ipmi -l ADMIN
> > > > > Fetching SDR repository information... done
> > > > > Fetching record 91 of 92 (current record ID 92)
> > > > > SDR Cache load failed: cache invalid
> > > > >
> > > > > The released version works, so there must have been some format change 
> > > > > in the SDR Cache that is causing a problem.
> > > > >   
> > > > >
> > > > >          
> > > > You're right.  There has been a format change to the SDR cache.  I did
> > > > add a bit more "tightness" to the parsing, perhaps not ignoring as many
> > > > parsing errors as the prior code may have allowed before.
> > > >
> > > > Does this bug only occur when you create the SDR cache?  Does the
> > > > failure also happen when you re-run ipmi-sel and it attempts to re-load
> > > > the SDR cache?
> > > >
> > > >
> > > >        
> > > I am not sure where it is occuring, but it seems to build the SDR cache 
> > > ok, but then fails when it tries to use it.  If I do a flush, it will 
> > > then rebuild it, but then fail to use it.  The following is what I get 
> > > when I re-run the program after the cache is build.
> > >
> > > address@hidden:~/freeipmi/freeipmi> ./ipmi-sel/src/ipmi-sel -D LAN -h 
> > > bmc1 -u admin -p ipmi -l ADMIN
> > > SDR Cache load failed: cache invalid; SDR cache may need to be flushed 
> > > and reloaded
> > >
> > > Attached is the SDR cache file that is built.
> > >
> > > Thanks for your help,  Tom Zimmerman
> > >
> > >      
> > >
> > > > Is it possible you could send me the SDR cache file itself?  That way I
> > > > can find out what the weird corner case parsing issue is.  Then file
> > > > would be in ~/.freeipmi/sdr-cache/.
> > > >
> > > > Thanks,
> > > > Al
> > > >
> > > >
> > > >
> > > >        
> > > >
> > > > > If anyone has information on this, please let me know.
> > > > >
> > > > > Thanks,  Tom Zimmerman
> > > > >
> > > > >
> > > > >
> > > > > _______________________________________________
> > > > > Freeipmi-devel mailing list
> > > > > address@hidden
> > > > > http://lists.gnu.org/mailman/listinfo/freeipmi-devel
> > > > >   
> > > > >
> > > > >