Re: [Freeipmi-devel] hardcoded path to ipmi-sensors in ipmimonitoring script caused problems in Gentoo

[Werner Fischer]

Thanks for the hint - i'll forward it to the gentoo people.

Best regards,
Werner

On Sun, 2011-06-19 at 12:23 -0700, Al Chu wrote:
> Sorry, you need to look at ipmimonitoring.in.  When you run ./configure,
> it'll replace @IPMIMONITORINGSBINDIR@ and create ipmimonitoring.
> 
> Al
> 
> On Sat, 2011-06-18 at 09:35 -0700, Werner Fischer wrote:
> > Hi Al,
> > 
> > I have extracted the freeipmi-1.0.4.tar.gz tarball and the last line of
> > the file ./ipmi-sensors/src/ipmimonitoring contains:
> >         address@hidden:~/freeipmi-1.0.4$ tail -1 
> > ./ipmi-sensors/src/ipmimonitoring
> >         exec /usr/local/sbin/ipmi-sensors $options
> > 
> > You mentioned that this should be:
> >         exec @IPMIMONITORINGSBINDIR@/ipmi-sensors $options
> > 
> > Am I looking at a wrong file or is the script in the tarball maybe wrong?
> > 
> > Best regards,
> > Werner
> > 
> > On Fri, 2011-06-10 at 08:57 -0700, Al Chu wrote:
> > > Hi Werner,
> > > 
> > > This is normally something that is handled within the build system.  I'm
> > > not familiar with debian/gentoo, so I can't really comment on how the
> > > build systems work (perhaps Yaroslav is watching and can comment).
> > > 
> > > If you look at the code, you'll see that the script line is:
> > > 
> > > exec @IPMIMONITORINGSBINDIR@/ipmi-sensors $options
> > > 
> > > and the appropriate path is put in via configure.
> > > 
> > > Al
> > > 
> > > On Fri, 2011-06-10 at 07:27 -0700, Werner Fischer wrote:
> > > > Hi Al,
> > > > 
> > > > our Nagios/Icinga IPMI is meanwhile available in Gentoo as an ebuild,
> > > > just like FreeIPMI is, too:
> > > > http://packages.gentoo.org/package/net-analyzer/nagios-check_ipmi_sensor
> > > > http://packages.gentoo.org/package/sys-libs/freeipmi
> > > > 
> > > > In a bug report for the plugin Rolf Eike Beer mentions that the
> > > > hardcoded path to ipmi-sensors in the ipmimonitoring script of FreeIPMI
> > > > 1.0.4 caused troubles in Gentoo:
> > > >         "Additionally the file /usr/sbin/ipmimonitoring in 1.0.4 has a
> > > >         hardcoded path to /usr/local/sbin/ipmi-sensors which is
> > > >         in /usr/sbin instead."
> > > > See: http://bugs.gentoo.org/show_bug.cgi?id=367357#c1
> > > > 
> > > > The ipmimonitoring script has the following last line:
> > > >         exec /usr/local/sbin/ipmi-sensors $options
> > > > 
> > > > With the plugin I had the same issue regarding setting the location of
> > > > ipmimonitoring. I resolved it there with the following part (but the
> > > > plugin requires /bin/bash, I'm not sure whether this works also with
> > > > other shells in this way...)
> > > >         if [ -x "/usr/sbin/ipmimonitoring" ]; then 
> > > > IPMICOMMAND="/usr/sbin/ipmimonitoring"
> > > >         elif [ -x "/usr/bin/ipmimonitoring" ]; then 
> > > > IPMICOMMAND="/usr/bin/ipmimonitoring"
> > > >         elif [ -x "/usr/local/sbin/ipmimonitoring" ]; then 
> > > > IPMICOMMAND="/usr/local/sbin/ipmimonitoring"
> > > >         fi
> > > > 
> > > > Do you see an option how you could modify the ipmimonitoring script so
> > > > that it also works when ipmi-sensors is not in /usr/local/sbin/ but
> > > > in /usr/sbin instead?
> > > > 
> > > > Best regards,
> > > > Werner
> > > > 
> > 

-- 
: Werner Fischer
: Technology Specialist
: Thomas-Krenn.AG | The server-experts
: http://www.thomas-krenn.com | http://www.thomas-krenn.com/wiki