Re: [Freeipmi-devel] [PATCH 2/2] build: fix inclusion of freeipmi.h header from system itself.

[Al Chu]

Hey Diego,

I'm a little confused on the build problem this fixes.  For ipmidetect,
it shouldn't be including libfreeipmi headers at all.  In the daemonutil
case, the appropriate tools should be including libfreeipmi headers in
their makefiles.

Perhaps there's a "chain" of inclusions/linking that I'm missing, or
there is an errant inclusion of a freeipmi.h where it shouldn't.  Can
you show me what the build problem is?

Al

On Fri, 2012-05-04 at 23:33 -0700, Diego Elio Pettenò wrote:
> Signed-off-by: Diego Elio Pettenò <address@hidden>
> ---
>  common/daemonutil/Makefile.am |    1 +
>  ipmidetect/Makefile.am        |    1 +
>  2 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/common/daemonutil/Makefile.am b/common/daemonutil/Makefile.am
> index cf40c40..5bed4c0 100644
> --- a/common/daemonutil/Makefile.am
> +++ b/common/daemonutil/Makefile.am
> @@ -4,6 +4,7 @@ noinst_LTLIBRARIES = \
>  libdaemonutil_la_CPPFLAGS = \
>       -I$(top_srcdir)/common/miscutil \
>       -I$(top_srcdir)/common/portability \
> +     -I$(top_srcdir)/libfreeipmi/include \
>       -D_GNU_SOURCE \
>       -D_REENTRANT
>  
> diff --git a/ipmidetect/Makefile.am b/ipmidetect/Makefile.am
> index 5230aff..8f05aa3 100644
> --- a/ipmidetect/Makefile.am
> +++ b/ipmidetect/Makefile.am
> @@ -10,6 +10,7 @@ ipmidetect_CPPFLAGS = \
>       -I$(top_srcdir)/common/miscutil \
>       -I$(top_srcdir)/common/portability \
>       -I$(top_srcdir)/libipmidetect/ \
> +     -I$(top_srcdir)/libfreeipmi/include \
>       -D_GNU_SOURCE \
>       -D_REENTRANT
>  
-- 
Albert Chu
address@hidden
Computer Scientist
High Performance Systems Division
Lawrence Livermore National Laboratory