Re: [Freeipmi-devel] [PATCH] Add support for Supermicro H8DGU-F to ipmi-sensors.

[Al Chu]

Hi Diego,

Applied, thanks.  I also added the support for ipmi-sel and the
--output-sensor-state/--output-event-state options.

However, proper --output-sensor-state support, I need to know what the
motherboard manufactuer ID is from bmc-info.  Normally I don't need to
ask, but too many Supermicro motherboards come with invalid IDs.  I
simply guessed it was the 47488 ID.

Al

On Sat, 2012-05-05 at 10:44 -0700, Diego Elio Pettenò wrote:
> Signed-off-by: Diego Elio Pettenò <address@hidden>
> ---
>  .../include/freeipmi/spec/ipmi-product-id-spec.h   |    1 +
>  .../util/ipmi-sensor-and-event-code-tables-util.c  |    3 ++-
>  2 files changed, 3 insertions(+), 1 deletions(-)
> 
> diff --git a/libfreeipmi/include/freeipmi/spec/ipmi-product-id-spec.h 
> b/libfreeipmi/include/freeipmi/spec/ipmi-product-id-spec.h
> index 516c5f9..5c5a0df 100644
> --- a/libfreeipmi/include/freeipmi/spec/ipmi-product-id-spec.h
> +++ b/libfreeipmi/include/freeipmi/spec/ipmi-product-id-spec.h
> @@ -219,6 +219,7 @@ extern "C" {
>  #define IPMI_SUPERMICRO_PRODUCT_ID_X8DTNPLUS_F 1551
>  #define IPMI_SUPERMICRO_PRODUCT_ID_X8SIE       1037
>  #define IPMI_SUPERMICRO_PRODUCT_ID_X9SCA_F_O   1585
> +#define IPMI_SUPERMICRO_PRODUCT_ID_H8DGU_F     43025
>  
>  /* Seen in the wild w/ proper IANA number 10876 */
>  /* defined above: IPMI_SUPERMICRO_PRODUCT_ID_X9SCM */
> diff --git a/libfreeipmi/util/ipmi-sensor-and-event-code-tables-util.c 
> b/libfreeipmi/util/ipmi-sensor-and-event-code-tables-util.c
> index 0e9c475..68d2718 100644
> --- a/libfreeipmi/util/ipmi-sensor-and-event-code-tables-util.c
> +++ b/libfreeipmi/util/ipmi-sensor-and-event-code-tables-util.c
> @@ -2153,7 +2153,8 @@ _supermicro_oem_temp_level_sensor_supported (uint32_t 
> manufacturer_id, uint16_t
>             || product_id == IPMI_SUPERMICRO_PRODUCT_ID_X9SCM
>             || product_id == IPMI_SUPERMICRO_PRODUCT_ID_X8DTNPLUS_F
>             || product_id == IPMI_SUPERMICRO_PRODUCT_ID_X8SIE
> -           || product_id == IPMI_SUPERMICRO_PRODUCT_ID_X9SCA_F_O))
> +           || product_id == IPMI_SUPERMICRO_PRODUCT_ID_X9SCA_F_O
> +           || product_id == IPMI_SUPERMICRO_PRODUCT_ID_H8DGU_F))
>        || (manufacturer_id == IPMI_IANA_ENTERPRISE_ID_MAGNUM_TECHNOLOGIES
>         && product_id == IPMI_SUPERMICRO_PRODUCT_ID_X8DTL))
>      return (1);
-- 
Albert Chu
address@hidden
Computer Scientist
High Performance Systems Division
Lawrence Livermore National Laboratory