Re: [Freeipmi-devel] Submitting patches

Adding in Dann Frazier to thread

On Wed, Sep 23, 2015 at 1:50 PM, Albert Chu <address@hidden> wrote:

Hi Newell,

Hmmm, I'm not sure if your patch is the right approach. While there may
be a problem w/ /dev/mem on your system, it may not be something that
exists on all systems. Or if it's a bug, it may be fixed in the future.
So just removing the probes on arm64 may not be the best choice.

Perhaps a better option would be to create a set of options in
ipmi-locate to limit what probes to do? That way (if you're scripting
this), you can avoid the probing of known problem areas?

It probably wouldn't be hard to add a bunch of the options. Do you
think that'd suffice?

Al

On Wed, 2015-09-23 at 12:53 -0700, Newell Jensen wrote:
> Al,
>
>
> Below (and attached) is the patch. Using this patch I was able to get
> past the issues that we were seeing. The main issue is that the code
> for the three probe displays below is using /dev/mem and this is an
> issue with the arm64 hardware that we have. Let me know your
> thoughts.
>
>
> Index: ipmi-locate/ipmi-locate.c
> ===================================================================
> --- ipmi-locate/ipmi-locate.c (revision 10210)
> +++ ipmi-locate/ipmi-locate.c (working copy)
> @@ -537,9 +537,11 @@
> exit (EXIT_FAILURE);
> }
>
> +#ifndef __aarch64__
> dmidecode_probe_display (ctx);
> smbios_probe_display (ctx);
> acpi_probe_display (ctx);
> +#endif
> pci_probe_display (ctx);
> if (cmd_args.defaults)
> defaults_display (ctx);
>
>
>
> On Wed, Sep 23, 2015 at 10:49 AM, Albert Chu <address@hidden> wrote:
> Hi Newell,
>
> Just post the patch here on the mailing list and we can
> iterate over it.
>
> Al
>
> On Wed, 2015-09-23 at 10:45 -0700, Newell Jensen wrote:
> > Hello,
> >
> >
> > I have been running into an error with arm64 based hardware
> that is
> > running ipmi-locate:
> >
> >
> > $ sudo strace -f ipmi-locate
> > execve("/usr/sbin/ipmi-locate", ["ipmi-locate"], [/* 13 vars
> */]) = 0
> > brk(0) = 0xffffa12b4000
> > faccessat(AT_FDCWD, "/etc/ld.so.nohwcap", F_OK) = -1 ENOENT
> (No such
> > file or directory)
> > mmap(NULL, 8192, PROT_READ|PROT_WRITE, MAP_PRIVATE|
> MAP_ANONYMOUS, -1,
> > 0) = 0xffff80484000
> > faccessat(AT_FDCWD, "/etc/ld.so.preload", R_OK) = -1 ENOENT
> (No such
> > file or directory)
> > openat(AT_FDCWD, "/etc/ld.so.cache", O_RDONLY|O_CLOEXEC) = 3
> > fstat(3, {st_mode=S_IFREG|0644, st_size=30292, ...}) = 0
> > mmap(NULL, 30292, PROT_READ, MAP_PRIVATE, 3, 0) =
> 0xffff8047c000
> > close(3) = 0
> > faccessat(AT_FDCWD, "/etc/ld.so.nohwcap", F_OK) = -1 ENOENT
> (No such
> > file or directory)
> > openat(AT_FDCWD, "/usr/lib/libfreeipmi.so.12", O_RDONLY|
> O_CLOEXEC) = 3
> > read(3, "\177ELF\2\1\1\0\0\0\0\0\0\0\0\0\3\0\267\0\1\0\0\0
> \200\361\21
> > \0\0\0\0\0"..., 832) = 832
> > fstat(3, {st_mode=S_IFREG|0644, st_size=4443888, ...}) = 0
> > mmap(NULL, 4507696, PROT_READ|PROT_EXEC, MAP_PRIVATE|
> MAP_DENYWRITE, 3,
> > 0) = 0xffff80010000
> > mprotect(0xffff802a5000, 65536, PROT_NONE) = 0
> > mmap(0xffff802b5000, 1736704, PROT_READ|PROT_WRITE,
> MAP_PRIVATE|
> > MAP_FIXED|MAP_DENYWRITE, 3, 0x295000) = 0xffff802b5000
> > close(3) = 0
> > faccessat(AT_FDCWD, "/etc/ld.so.nohwcap", F_OK) = -1 ENOENT
> (No such
> > file or directory)
> > openat(AT_FDCWD, "/lib/aarch64-linux-gnu/libc.so.6",
> O_RDONLY|
> > O_CLOEXEC) = 3
> > read(3, "\177ELF\2\1\1\0\0\0\0\0\0\0\0\0\3\0\267\0\1\0\0\0
> \250\16\2\0
> > \0\0\0\0"..., 832) = 832
> > fstat(3, {st_mode=S_IFREG|0755, st_size=1275592, ...}) = 0
> > mmap(NULL, 1348480, PROT_READ|PROT_EXEC, MAP_PRIVATE|
> MAP_DENYWRITE, 3,
> > 0) = 0xffff7fec6000
> > mprotect(0xffff7fff7000, 61440, PROT_NONE) = 0
> > mmap(0xffff80006000, 24576, PROT_READ|PROT_WRITE,
> MAP_PRIVATE|
> > MAP_FIXED|MAP_DENYWRITE, 3, 0x130000) = 0xffff80006000
> > mmap(0xffff8000c000, 13184, PROT_READ|PROT_WRITE,
> MAP_PRIVATE|
> > MAP_FIXED|MAP_ANONYMOUS, -1, 0) = 0xffff8000c000
> > close(3) = 0
> > faccessat(AT_FDCWD, "/etc/ld.so.nohwcap", F_OK) = -1 ENOENT
> (No such
> > file or directory)
> > openat(AT_FDCWD, "/lib/aarch64-linux-gnu/libgcrypt.so.11",
> O_RDONLY|
> > O_CLOEXEC) = 3
> > read(3, "\177ELF\2\1\1\0\0\0\0\0\0\0\0\0\3\0\267\0\1\0\0\0
> \300~\0\0\0
> > \0\0\0"..., 832) = 832
> > fstat(3, {st_mode=S_IFREG|0644, st_size=474496, ...}) = 0
> > mmap(NULL, 4096, PROT_READ|PROT_WRITE, MAP_PRIVATE|
> MAP_ANONYMOUS, -1,
> > 0) = 0xffff8047b000
> > mmap(NULL, 473688, PROT_READ|PROT_EXEC, MAP_PRIVATE|
> MAP_DENYWRITE, 3,
> > 0) = 0xffff7fe52000
> > mmap(0xffff7fec2000, 16384, PROT_READ|PROT_WRITE,
> MAP_PRIVATE|
> > MAP_FIXED|MAP_DENYWRITE, 3, 0x70000) = 0xffff7fec2000
> > close(3) = 0
> > faccessat(AT_FDCWD, "/etc/ld.so.nohwcap", F_OK) = -1 ENOENT
> (No such
> > file or directory)
> > openat(AT_FDCWD, "/lib/aarch64-linux-gnu/libm.so.6",
> O_RDONLY|
> > O_CLOEXEC) = 3
> > read(3, "\177ELF\2\1\1\0\0\0\0\0\0\0\0\0\3\0\267\0\1\0\0\0
> \240R\0\0\0
> > \0\0\0"..., 832) = 832
> > fstat(3, {st_mode=S_IFREG|0644, st_size=588696, ...}) = 0
> > mmap(NULL, 651944, PROT_READ|PROT_EXEC, MAP_PRIVATE|
> MAP_DENYWRITE, 3,
> > 0) = 0xffff7fdb2000
> > mprotect(0xffff7fe41000, 61440, PROT_NONE) = 0
> > mmap(0xffff7fe50000, 8192, PROT_READ|PROT_WRITE,
> MAP_PRIVATE|
> > MAP_FIXED|MAP_DENYWRITE, 3, 0x8e000) = 0xffff7fe50000
> > close(3) = 0
> > faccessat(AT_FDCWD, "/etc/ld.so.nohwcap", F_OK) = -1 ENOENT
> (No such
> > file or directory)
> > openat(AT_FDCWD, "/lib/aarch64-linux-gnu/libgpg-error.so.0",
> O_RDONLY|
> > O_CLOEXEC) = 3
> > read(3, "\177ELF\2\1\1\0\0\0\0\0\0\0\0\0\3\0\267\0\1\0\0\0\0
> \n\0\0\0\0
> > \0\0"..., 832) = 832
> > fstat(3, {st_mode=S_IFREG|0644, st_size=18312, ...}) = 0
> > mmap(NULL, 82008, PROT_READ|PROT_EXEC, MAP_PRIVATE|
> MAP_DENYWRITE, 3,
> > 0) = 0xffff7fd9d000
> > mprotect(0xffff7fda0000, 65536, PROT_NONE) = 0
> > mmap(0xffff7fdb0000, 8192, PROT_READ|PROT_WRITE,
> MAP_PRIVATE|
> > MAP_FIXED|MAP_DENYWRITE, 3, 0x3000) = 0xffff7fdb0000
> > close(3) = 0
> > mmap(NULL, 4096, PROT_READ|PROT_WRITE, MAP_PRIVATE|
> MAP_ANONYMOUS, -1,
> > 0) = 0xffff8047a000
> > mmap(NULL, 4096, PROT_READ|PROT_WRITE, MAP_PRIVATE|
> MAP_ANONYMOUS, -1,
> > 0) = 0xffff80479000
> > mprotect(0xffff80006000, 16384, PROT_READ) = 0
> > mprotect(0xffff7fdb0000, 4096, PROT_READ) = 0
> > mprotect(0xffff7fe50000, 4096, PROT_READ) = 0
> > mprotect(0xffff7fec2000, 4096, PROT_READ) = 0
> > mprotect(0xffff802b5000, 339968, PROT_READ) = 0
> > mprotect(0xffff8049e000, 4096, PROT_READ) = 0
> > mprotect(0xffff80488000, 4096, PROT_READ) = 0
> > munmap(0xffff8047c000, 30292) = 0
> > brk(0) = 0xffffa12b4000
> > brk(0xffffa12d5000) = 0xffffa12d5000
> > getrlimit(RLIMIT_CORE, {rlim_cur=0,
> rlim_max=RLIM64_INFINITY}) = 0
> > setrlimit(RLIMIT_CORE, {rlim_cur=0,
> rlim_max=RLIM64_INFINITY}) = 0
> > getuid() = 0
> > fstat(1, {st_mode=S_IFCHR|0620, st_rdev=makedev(136,
> 0), ...}) = 0
> > mmap(NULL, 65536, PROT_READ|PROT_WRITE, MAP_PRIVATE|
> MAP_ANONYMOUS, -1,
> > 0) = 0xffff7fd8d000
> > openat(AT_FDCWD, "/proc/efi/systab", O_RDONLY) = -1 ENOENT
> (No such
> > file or directory)
> > openat(AT_FDCWD, "/sys/firmware/efi/systab", O_RDONLY) = 3
> > fstat(3, {st_mode=S_IFREG|0400, st_size=4096, ...}) = 0
> > mmap(NULL, 65536, PROT_READ|PROT_WRITE, MAP_PRIVATE|
> MAP_ANONYMOUS, -1,
> > 0) = 0xffff7fd7d000
> > read(3, "ACPI20=0xfffff014\nACPI=0xfffff00"..., 4096) = 34
> > read(3, "", 4096) = 0
> > close(3) = 0
> > munmap(0xffff7fd7d000, 65536) = 0
> > write(1, "Probing KCS device using DMIDECO"..., 45Probing
> KCS device
> > using DMIDECODE... FAILED
> > ) = 45
> > write(1, "\n", 1
> > ) = 1
> > openat(AT_FDCWD, "/proc/efi/systab", O_RDONLY) = -1 ENOENT
> (No such
> > file or directory)
> > openat(AT_FDCWD, "/sys/firmware/efi/systab", O_RDONLY) = 3
> > fstat(3, {st_mode=S_IFREG|0400, st_size=4096, ...}) = 0
> > mmap(NULL, 65536, PROT_READ|PROT_WRITE, MAP_PRIVATE|
> MAP_ANONYMOUS, -1,
> > 0) = 0xffff7fd7d000
> > read(3, "ACPI20=0xfffff014\nACPI=0xfffff00"..., 4096) = 34
> > read(3, "", 4096) = 0
> > close(3) = 0
> > munmap(0xffff7fd7d000, 65536) = 0
> > write(1, "Probing SMIC device using DMIDEC"..., 46Probing
> SMIC device
> > using DMIDECODE... FAILED
> > ) = 46
> > write(1, "\n", 1
> > ) = 1
> > openat(AT_FDCWD, "/proc/efi/systab", O_RDONLY) = -1 ENOENT
> (No such
> > file or directory)
> > openat(AT_FDCWD, "/sys/firmware/efi/systab", O_RDONLY) = 3
> > fstat(3, {st_mode=S_IFREG|0400, st_size=4096, ...}) = 0
> > mmap(NULL, 65536, PROT_READ|PROT_WRITE, MAP_PRIVATE|
> MAP_ANONYMOUS, -1,
> > 0) = 0xffff7fd7d000
> > read(3, "ACPI20=0xfffff014\nACPI=0xfffff00"..., 4096) = 34
> > read(3, "", 4096) = 0
> > close(3) = 0
> > munmap(0xffff7fd7d000, 65536) = 0
> > write(1, "Probing BT device using DMIDECOD"..., 44Probing BT
> device
> > using DMIDECODE... FAILED
> > ) = 44
> > write(1, "\n", 1
> > ) = 1
> > openat(AT_FDCWD, "/proc/efi/systab", O_RDONLY) = -1 ENOENT
> (No such
> > file or directory)
> > openat(AT_FDCWD, "/sys/firmware/efi/systab", O_RDONLY) = 3
> > fstat(3, {st_mode=S_IFREG|0400, st_size=4096, ...}) = 0
> > mmap(NULL, 65536, PROT_READ|PROT_WRITE, MAP_PRIVATE|
> MAP_ANONYMOUS, -1,
> > 0) = 0xffff7fd7d000
> > read(3, "ACPI20=0xfffff014\nACPI=0xfffff00"..., 4096) = 34
> > read(3, "", 4096) = 0
> > close(3) = 0
> > munmap(0xffff7fd7d000, 65536) = 0
> > write(1, "Probing SSIF device using DMIDEC"..., 46Probing
> SSIF device
> > using DMIDECODE... FAILED
> > ) = 46
> > write(1, "\n", 1
> > ) = 1
> > openat(AT_FDCWD, "/dev/mem", O_RDONLY|O_SYNC) = 3
> > mmap(NULL, 65536, PROT_READ, MAP_PRIVATE, 3, 0xf0000) =
> 0xffff7fd7d000
> > close(3) = 0
> > --- SIGBUS {si_signo=SIGBUS, si_code=SI_USER,
> si_pid=2144849920,
> > si_uid=65535} ---
> > +++ killed by SIGBUS (core dumped) +++
> >
> >
> >
> >
> > I have created a patch for this and was wondering what step
> I need to
> > get this landed upstream with you guys?
> >
> >
> > Thanks,
> >
> >
> > Newell
>
> > _______________________________________________
> > Freeipmi-devel mailing list
> > address@hidden
> > https://lists.gnu.org/mailman/listinfo/freeipmi-devel
> --
> Albert Chu
> address@hidden
> Computer Scientist
> High Performance Systems Division
> Lawrence Livermore National Laboratory
>
>
>
>
--
Albert Chu
address@hidden
Computer Scientist
High Performance Systems Division
Lawrence Livermore National Laboratory

From:	Newell Jensen
Subject:	Re: [Freeipmi-devel] Submitting patches
Date:	Thu, 24 Sep 2015 08:29:11 -0700