[Git][freetype/freetype-demos][gsoc-2022-chariri-3] 2 commits: * src/fti

Charlie Jiang pushed to branch gsoc-2022-chariri-3 at FreeType / FreeType Demo Programs

Commits:

ef14bfd2

by Charlie Jiang at 2022-08-19T16:54:23+08:00

* src/ftinspect/engine/engine.cpp: Support LCD rendering.

It was a great decision to refactor the color table part.

6b689304

by Charlie Jiang at 2022-08-19T22:38:19+08:00

[ftinspect] Fix crashing on bitmap-only fonts.

See #16. Unscalable fonts still can't be rendered properly, though.

* src/ftinspect/engine/engine.cpp, src/ftinspect/engine/engine.hpp:
  Add `ftFallbackFace_`, and lookup the face before the size. All accessing
  to the face when not rendering (e.g. retrieving font info) is changed to
  use the fallback face in case the size is invalid due to non-scalable
  font.
  Add `renderReady` and `fontValid` to indicate if the size or the face is
  valid. Use those two getters instead of checking the current glyph count
  for validity.

* src/ftinspect/engine/fontinfo.cpp, src/ftinspect/engine/mmgx.cpp,
  src/ftinspect/panels/info.cpp:
  Use fallback face instead of the size to retrieve font info.

* src/ftinspect/engine/stringrenderer.cpp,
  src/ftinspect/rendering/glyphcontinuous.cpp,
  src/ftinspect/rendering/glyphcontinuous.hpp: Fix crash with `renderReady`.

* src/ftinspect/widgets/tripletselector.cpp:
  Fix undesired infinite font reloading due to bad ppem value.

9 changed files:

src/ftinspect/engine/engine.cpp
src/ftinspect/engine/engine.hpp
src/ftinspect/engine/fontinfo.cpp
src/ftinspect/engine/mmgx.cpp
src/ftinspect/engine/stringrenderer.cpp
src/ftinspect/panels/info.cpp
src/ftinspect/rendering/glyphcontinuous.cpp
src/ftinspect/rendering/glyphcontinuous.hpp
src/ftinspect/widgets/tripletselector.cpp

Changes:

src/ftinspect/engine/engine.cpp

@@ -124,6 +124,7 @@ faceRequester(FTC_FaceID ftcFaceID,
  Engine::Engine()
+ {
    ftSize_ = NULL;
 +  ftFallbackFace_ = NULL;
    // we reserve value 0 for the `invalid face ID'
    faceCounter_ = 1;
@@ -292,8 +293,18 @@ Engine::loadFont(int fontIndex,
    if (scaler_.face_id)
+   {
      // found
 -    if (!FTC_Manager_LookupSize(cacheManager_, &scaler_, &ftSize_))
 -      numGlyphs = ftSize_->face->num_glyphs;
 +    if (!FTC_Manager_LookupFace(cacheManager_, scaler_.face_id,
 +                               &ftFallbackFace_))
 +    {
 +      numGlyphs = ftFallbackFace_->num_glyphs;
 +      if (FTC_Manager_LookupSize(cacheManager_, &scaler_, &ftSize_))
 +        ftSize_ = NULL; // Good font, bad size.
 +    }
 +    else
 +    {
 +      ftFallbackFace_ = NULL;
 +      ftSize_ = NULL;
 +    }
+   }
    else if (fontIndex >= 0)
+   {
@@ -305,12 +316,19 @@ Engine::loadFont(int fontIndex,
      scaler_.face_id = reinterpret_cast<FTC_FaceID>(faceCounter_);
      faceIDMap_.insert(id, faceCounter_++);
 -    if (!FTC_Manager_LookupSize(cacheManager_, &scaler_, &ftSize_))
 -      numGlyphs = ftSize_->face->num_glyphs;
 +    if (!FTC_Manager_LookupFace(cacheManager_, scaler_.face_id,
 +                                &ftFallbackFace_))
 +    {
 +      numGlyphs = ftFallbackFace_->num_glyphs;
 +      if (FTC_Manager_LookupSize(cacheManager_, &scaler_, &ftSize_))
 +        ftSize_ = NULL; // Good font, bad size.
 +    }
      else
+     {
        faceIDMap_.remove(id);
        faceCounter_--;
 +      ftFallbackFace_ = NULL;
 +      ftSize_ = NULL;
+     }
+   }
@@ -318,6 +336,7 @@ Engine::loadFont(int fontIndex,
    if (numGlyphs < 0)
+   {
 +    ftFallbackFace_ = NULL;
      ftSize_ = NULL;
      curFamilyName_ = QString();
      curStyleName_ = QString();
@@ -328,11 +347,10 @@ Engine::loadFont(int fontIndex,
+   }
    else
+   {
 -    auto face = ftSize_->face;
 -    curFamilyName_ = QString(face->family_name);
 -    curStyleName_ = QString(face->style_name);
 +    curFamilyName_ = QString(ftFallbackFace_->family_name);
 +    curStyleName_ = QString(ftFallbackFace_->style_name);
 -    const char* moduleName = FT_FACE_DRIVER_NAME( face );
 +    const char* moduleName = FT_FACE_DRIVER_NAME(ftFallbackFace_);
      // XXX cover all available modules
      if (!strcmp(moduleName, "cff"))
@@ -341,9 +359,9 @@ Engine::loadFont(int fontIndex,
        fontType_ = FontType_TrueType;
      curCharMaps_.clear();
 -    curCharMaps_.reserve(face->num_charmaps);
 -    for (int i = 0; i < face->num_charmaps; i++)
 -      curCharMaps_.emplace_back(i, face->charmaps[i]);
 +    curCharMaps_.reserve(ftFallbackFace_->num_charmaps);
 +    for (int i = 0; i < ftFallbackFace_->num_charmaps; i++)
 +      curCharMaps_.emplace_back(i, ftFallbackFace_->charmaps[i]);
      SFNTName::get(this, curSFNTNames_);
      loadPaletteInfos();
@@ -362,6 +380,7 @@ Engine::reloadFont()
    if (!scaler_.face_id)
      return;
    imageType_.face_id = scaler_.face_id;
 +  FTC_Manager_LookupFace(cacheManager_, scaler_.face_id, &ftFallbackFace_);
    FTC_Manager_LookupSize(cacheManager_, &scaler_, &ftSize_);
+ }
@@ -375,6 +394,9 @@ Engine::loadPalette()
        || paletteData_.num_palettes <= paletteIndex_)
      return;
 +  if (!ftSize_)
 +    return;
++
    FT_Palette_Select(ftSize_->face,
                      static_cast<FT_UShort>(paletteIndex_),
                      &palette_);
@@ -436,6 +458,9 @@ Engine::currentFaceSlot()
  FT_Pos
  Engine::currentFontTrackingKerning(int degree)
+ {
 +  if (!ftSize_)
 +    return 0;
++
    FT_Pos result;
    // this function needs and returns points, not pixels
    if (!FT_Get_Track_Kerning(ftSize_->face,
@@ -513,16 +538,14 @@ Engine::glyphName(int index)
    if (index < 0)
      throw std::runtime_error("Invalid glyph index");
 -  if (!ftSize_)
 -    return "";
+-
 -  if (!FTC_Manager_LookupSize(cacheManager_, &scaler_, &ftSize_))
 +  FT_Face face = NULL;
 +  if (FTC_Manager_LookupFace(cacheManager_, scaler_.face_id, &face))
      return name;
 -  if (ftSize_ && FT_HAS_GLYPH_NAMES(ftSize_->face))
 +  if (face && FT_HAS_GLYPH_NAMES(face))
+   {
      char buffer[256];
 -    if (!FT_Get_Glyph_Name(ftSize_->face,
 +    if (!FT_Get_Glyph_Name(face,
                             static_cast<unsigned int>(index),
                             buffer,
                             sizeof(buffer)))
@@ -649,6 +672,20 @@ Engine::convertBitmapTo8Bpp(FT_Bitmap* bitmap)
+ }
 +bool
 +Engine::renderReady()
 +{
 +  return ftSize_ != NULL;
 +}
++
++
 +bool
 +Engine::fontValid()
 +{
 +  return ftFallbackFace_ != NULL;
 +}
++
++
  int
  Engine::numberOfOpenedFonts()
+ {
@@ -709,6 +746,7 @@ Engine::setCFFHintingMode(int mode)
+   {
      // reset the cache
      FTC_Manager_Reset(cacheManager_);
 +    ftFallbackFace_ = NULL;
      ftSize_ = NULL;
+   }
+ }
@@ -725,6 +763,7 @@ Engine::setTTInterpreterVersion(int version)
+   {
      // reset the cache
      FTC_Manager_Reset(cacheManager_);
 +    ftFallbackFace_ = NULL;
      ftSize_ = NULL;
+   }
+ }
@@ -753,6 +792,7 @@ Engine::setStemDarkening(bool darkening)
                    &noDarkening);
    // reset the cache
    FTC_Manager_Reset(cacheManager_);
 +  ftFallbackFace_ = NULL;
    ftSize_ = NULL;
+ }
@@ -931,7 +971,7 @@ Engine::loadPaletteInfos()
+ {
    curPaletteInfos_.clear();
 -  if (FT_Palette_Data_Get(ftSize_->face, &paletteData_))
 +  if (FT_Palette_Data_Get(ftFallbackFace_, &paletteData_))
+   {
      // XXX Error handling
      paletteData_.num_palettes = 0;
@@ -941,7 +981,7 @@ Engine::loadPaletteInfos()
    // size never exceeds max val of ushort.
    curPaletteInfos_.reserve(paletteData_.num_palettes);
    for (int i = 0; i < paletteData_.num_palettes; ++i)
 -    curPaletteInfos_.emplace_back(ftSize_->face, paletteData_, i,
 +    curPaletteInfos_.emplace_back(ftFallbackFace_, paletteData_, i,
                                    &curSFNTNames_);
+ }
@@ -987,18 +1027,70 @@ Engine::calculateForegroundTable()
  void
  convertLCDToARGB(FT_Bitmap& bitmap,
                   QImage& image,
 -                 bool isBGR)
 +                 bool isBGR,
 +                 QVector<QRgb>& colorTable)
+ {
 -  // TODO to be implemented
 +  int height = bitmap.rows;
 +  int width = bitmap.width / 3;
 +  int width3 = bitmap.width;
++
 +  unsigned char* srcPtr = bitmap.buffer;
 +  unsigned* dstPtr = reinterpret_cast<unsigned*>(image.bits());
++
 +  int offR = !isBGR ? 0 : 2;
 +  int offG = 1;
 +  int offB = isBGR ? 0 : 2;
 +  for (int i = 0; i < height; i++)
 +  {
 +    for (int j = 0; j < width3; j += 3)
 +    {
 +      unsigned char ar = srcPtr[j + offR];
 +      unsigned char ag = srcPtr[j + offG];
 +      unsigned char ab = srcPtr[j + offB];
 +      unsigned dr = colorTable[ar] & 0xFF;
 +      unsigned dg = colorTable[ag] & 0xFF;
 +      unsigned db = colorTable[ab] & 0xFF;
 +      *dstPtr = (0xFFu << 24) | (dr << 16) | (dg << 8) | db;
 +      dstPtr++;
 +    }
 +    srcPtr += bitmap.pitch;
 +    dstPtr += image.bytesPerLine() / 4 - width; // skip blank area
 +  }
+ }
  void
  convertLCDVToARGB(FT_Bitmap& bitmap,
                    QImage& image,
 -                  bool isBGR)
 +                  bool isBGR,
 +                  QVector<QRgb>& colorTable)
+ {
 -  // TODO to be implemented
 +  int height = bitmap.rows / 3;
 +  int width = bitmap.width;
 +  int srcPitch = bitmap.pitch;
++
 +  unsigned char* srcPtr = bitmap.buffer;
 +  unsigned* dstPtr = reinterpret_cast<unsigned*>(image.bits());
++
 +  int offR = !isBGR ? 0 : 2 * srcPitch;
 +  int offG = srcPitch;
 +  int offB = isBGR ? 0 : 2 * srcPitch;
 +  for (int i = 0; i < height; i++)
 +  {
 +    for (int j = 0; j < width; j++)
 +    {
 +      unsigned char ar = srcPtr[j + offR];
 +      unsigned char ag = srcPtr[j + offG];
 +      unsigned char ab = srcPtr[j + offB];
 +      unsigned dr = colorTable[ar] & 0xFF;
 +      unsigned dg = colorTable[ag] & 0xFF;
 +      unsigned db = colorTable[ab] & 0xFF;
 +      *dstPtr = (0xFFu << 24) | (dr << 16) | (dg << 8) | db;
 +      dstPtr++;
 +    }
 +    srcPtr += 3ull * srcPitch;                  // move 3 lines
 +    dstPtr += image.bytesPerLine() / 4 - width; // skip blank area
 +  }
+ }
@@ -1076,11 +1168,11 @@ Engine::convertBitmapToQImage(FT_Bitmap* src)
      break;
    case FT_PIXEL_MODE_LCD:;
      result = new QImage(width, height, format);
 -    convertLCDToARGB(bmap, *result, lcdUsesBGR_);
 +    convertLCDToARGB(bmap, *result, lcdUsesBGR_, foregroundTable_);
      break;
    case FT_PIXEL_MODE_LCD_V:;
      result = new QImage(width, height, format);
 -    convertLCDVToARGB(bmap, *result, lcdUsesBGR_);
 +    convertLCDVToARGB(bmap, *result, lcdUsesBGR_, foregroundTable_);
      break;
+   }

src/ftinspect/engine/engine.hpp

@@ -131,9 +131,12 @@ public:
    int dpi() { return dpi_; }
    double pointSize() { return pointSize_; }
 +  bool renderReady();
 +  bool fontValid();
    int numberOfOpenedFonts();
    int currentFontIndex() { return curFontIndex_; }
 -  FT_Size currentFtSize() { return ftSize_; }
 +  FT_Face currentFallbackFtFace() { return ftFallbackFace_; }
 +  // FT_Size currentFtSize() { return ftSize_; }
    int currentFontType() const { return fontType_; }
    const QString& currentFamilyName() { return curFamilyName_; }
    const QString& currentStyleName() { return curStyleName_; }
@@ -247,6 +250,7 @@ private:
    FTC_ScalerRec scaler_ = {};
    FTC_ImageTypeRec imageType_;
 +  FT_Face ftFallbackFace_; // Never perform rendering or write to this!
    FT_Size ftSize_;
    FT_Palette_Data paletteData_ = {};
    FT_Color* palette_ = NULL;

src/ftinspect/engine/fontinfo.cpp

@@ -32,14 +32,13 @@ void
  SFNTName::get(Engine* engine,
                std::vector<SFNTName>& list)
+ {
 -  auto size = engine->currentFtSize();
 -  if (!size || !FT_IS_SFNT(size->face))
 +  auto face = engine->currentFallbackFtFace();
 +  if (!face || !FT_IS_SFNT(face))
+   {
      list.clear();
      return;
+   }
+-
 -  auto face = size->face;
++
    auto newSize = FT_Get_Sfnt_Name_Count(face);
    if (list.size() != static_cast<size_t>(newSize))
      list.resize(newSize);
@@ -184,11 +183,10 @@ FontBasicInfo::get(Engine* engine)
    result.numFaces = engine->numberOfFaces(fontIndex);
    engine->reloadFont();
 -  auto size = engine->currentFtSize();
 -  if (!size)
 +  auto face = engine->currentFallbackFtFace();
 +  if (!face)
      return result;
 -  auto face = size->face;
    if (face->family_name)
      result.familyName = QString(face->family_name);
    if (face->style_name)
@@ -228,12 +226,10 @@ FontTypeEntries
  FontTypeEntries::get(Engine* engine)
+ {
    engine->reloadFont();
 -  auto size = engine->currentFtSize();
 -  if (!size)
 +  auto face = engine->currentFallbackFtFace();
 +  if (!face)
      return {};
+-
 -  auto face = size->face;
+-
++
    FontTypeEntries result = {};
    result.driverName = QString(FT_FACE_DRIVER_NAME(face));
    result.sfnt = FT_IS_SFNT(face);
@@ -332,8 +328,8 @@ FontFixedSize::get(Engine* engine,
                     const std::function<void()>& onUpdateNeeded)
+ {
    engine->reloadFont();
 -  auto size = engine->currentFtSize();
 -  if (!size)
 +  auto face = engine->currentFallbackFtFace();
 +  if (!face)
+   {
      if (list.empty())
        return false;
@@ -342,8 +338,7 @@ FontFixedSize::get(Engine* engine,
      list.clear();
      return true;
+   }
+-
 -  auto face = size->face;
++
    auto changed = false;
    if (list.size() != static_cast<size_t>(face->num_fixed_sizes))
+   {
@@ -510,8 +505,8 @@ SFNTTableInfo::getForAll(Engine* engine,
                           std::vector<SFNTTableInfo>& infos)
+ {
    infos.clear();
 -  auto size = engine->currentFtSize();
 -  if (!size || !FT_IS_SFNT(size->face))
 +  auto face = engine->currentFallbackFtFace();
 +  if (!face || !FT_IS_SFNT(face))
      return;
    auto index = engine->currentFontIndex();

src/ftinspect/engine/mmgx.cpp


 MMGXAxisInfo::get(Engine* engine,
                   std::vector<MMGXAxisInfo>& infos)
 {
-  auto size = engine->currentFtSize();
-  if (!size)
+  auto face = engine->currentFallbackFtFace();
+  if (!face)
   {
     infos.clear();
     return MMGXState::NoMMGX;
   }
-  auto face = size->face;
 
   if (!FT_HAS_MULTIPLE_MASTERS(face))
   {

src/ftinspect/engine/stringrenderer.cpp

@@ -150,6 +150,8 @@ void
  StringRenderer::prepareRendering()
+ {
    engine_->reloadFont();
 +  if (!engine_->renderReady())
 +    return;
    engine_->loadPalette();
    if (kerningDegree_ != KD_None)
      trackingKerning_ = engine_->currentFontTrackingKerning(kerningDegree_);
@@ -346,11 +348,13 @@ StringRenderer::render(int width,
                         int height,
                         int offset)
+ {
 +  engine_->reloadFont();
++
    if (usingString_)
      offset = 0;
    if (!usingString_ && limitIndex_ <= 0)
      return 0;
 -  if (engine_->currentFontNumberOfGlyphs() <= 0)
 +  if (!engine_->fontValid())
      return 0;
    // Separated into 3 modes:
@@ -379,6 +383,8 @@ StringRenderer::render(int width,
        // 64.0 is somewhat a magic reference number
        engine_->setSizeByPoint(64.0);
        engine_->reloadFont();
 +      if (!engine_->renderReady())
 +        return -1; // TODO: Handle bitmap-only fonts
        auto pixelActual = engine_->currentFontMetrics().height >> 6;
        auto heightPt = height * 64.0 / pixelActual;
@@ -441,6 +447,8 @@ StringRenderer::render(int width,
      // Fill the whole canvas
      prepareRendering();
 +    if (!engine_->renderReady())
 +      return 0;
      auto& metrics = engine_->currentFontMetrics();
      auto y = 4 + static_cast<int>(metrics.ascender >> 6);
      auto stepY = static_cast<int>(metrics.height >> 6) + 1;
@@ -459,6 +467,9 @@ StringRenderer::render(int width,
    // Single string
    prepareRendering();
 +  if (!engine_->renderReady())
 +    return 0;
++
    auto& metrics = engine_->currentFontMetrics();
    auto x = static_cast<int>(width * position_);
    // Anchor at top-left in vertical mode, at the center in horizontal mode

src/ftinspect/panels/info.cpp

@@ -414,8 +414,8 @@ void
  SFNTInfoTab::reloadFont()
+ {
    engine_->reloadFont();
 -  auto size = engine_->currentFtSize();
 -  if (!size || !FT_IS_SFNT(size->face))
 +  auto face = engine_->currentFallbackFtFace();
 +  if (!face || !FT_IS_SFNT(face))
      setEnabled(false);
    if (engine_->currentFontSFNTNames() != sfntNamesModel_->storage())

src/ftinspect/rendering/glyphcontinuous.cpp

@@ -252,27 +252,30 @@ GlyphContinuous::paintByRenderer()
  void
  GlyphContinuous::transformGlyphFancy(FT_Glyph glyph)
+ {
 +  auto& metrics = engine_->currentFontMetrics();
 +  auto emboldeningX = (FT_Pos)(metrics.y_ppem * 64 * boldX_);
 +  auto emboldeningY = (FT_Pos)(metrics.y_ppem * 64 * boldY_);
    // adopted from ftview.c:289
    if (glyph->format == FT_GLYPH_FORMAT_OUTLINE)
+   {
      auto outline = reinterpret_cast<FT_OutlineGlyph>(glyph)->outline;
      FT_Glyph_Transform(glyph, &shearMatrix_, NULL);
 -    if (FT_Outline_EmboldenXY(&outline, emboldeningX_, emboldeningY_))
 +    if (FT_Outline_EmboldenXY(&outline, emboldeningX, emboldeningY))
+     {
        // XXX error handling?
        return;
+     }
      if (glyph->advance.x)
 -      glyph->advance.x += emboldeningX_;
 +      glyph->advance.x += emboldeningX;
      if (glyph->advance.y)
 -      glyph->advance.y += emboldeningY_;
 +      glyph->advance.y += emboldeningY;
+   }
    else if (glyph->format == FT_GLYPH_FORMAT_BITMAP)
+   {
 -    auto xstr = emboldeningX_ & ~63;
 -    auto ystr = emboldeningY_ & ~63;
 +    auto xstr = emboldeningX & ~63;
 +    auto ystr = emboldeningY & ~63;
      auto bitmap = &reinterpret_cast<FT_BitmapGlyph>(glyph)->bitmap;
      // No shearing support for bitmap
@@ -326,13 +329,6 @@ void
  GlyphContinuous::prePaint()
+ {
    displayingCount_ = 0;
 -  engine_->reloadFont();
 -  if (engine_->currentFontNumberOfGlyphs() > 0)
 -    metrics_ = engine_->currentFontMetrics();
 -  x_ = 0;
 -  // See ftview.c:42
 -  y_ = ((metrics_.ascender - metrics_.descender + 63) >> 6) + 4;
 -  stepY_ = ((metrics_.height + 63) >> 6) + 4;
    // Used by fancy:
    // adopted from ftview.c:289
@@ -355,18 +351,22 @@ GlyphContinuous::prePaint()
    shearMatrix_.xy = static_cast<FT_Fixed>(slant_ * (1 << 16));
    shearMatrix_.yx = 0;
    shearMatrix_.yy = 1 << 16;
 +}
 -  emboldeningX_ = (FT_Pos)(metrics_.y_ppem * 64 * boldX_);
 -  emboldeningY_ = (FT_Pos)(metrics_.y_ppem * 64 * boldY_);
 -  if (mode_ == M_Stroked)
 -  {
 -    auto radius = static_cast<FT_Fixed>(metrics_.y_ppem * 64 * strokeRadius_);
 -    FT_Stroker_Set(stroker_, radius,
 -                   FT_STROKER_LINECAP_ROUND,
 -                   FT_STROKER_LINEJOIN_ROUND,
 -                   0);
 -  }
 +void
 +GlyphContinuous::updateStroke()
 +{
 +  if (mode_ != M_Stroked || !engine_->renderReady())
 +    return;
++
 +  auto& metrics = engine_->currentFontMetrics();
 +  auto radius = static_cast<FT_Fixed>(metrics.y_ppem * 64 * strokeRadius_);
 +  strokeRadiusForSize_ = radius;
 +  FT_Stroker_Set(stroker_, radius,
 +                 FT_STROKER_LINECAP_ROUND,
 +                 FT_STROKER_LINEJOIN_ROUND,
 +                 0);
+ }
@@ -452,6 +452,7 @@ GlyphContinuous::saveSingleGlyphImage(QImage* image,
    entry.glyphIndex = gctx.glyphIndex;
    entry.advance = advance;
    entry.penPos = penPosPoint;
 +  entry.yPpem = engine_->currentFontMetrics().y_ppem;
+ }
@@ -486,7 +487,7 @@ GlyphContinuous::drawCacheGlyph(QPainter* painter,
    // ftview.c:557
    // Well, metrics is also part of the cache...
    int width = entry.advance.x ? entry.advance.x >> 16
 -                              : metrics_.y_ppem / 2;
 +                              : entry.yPpem / 2;
    if (entry.advance.x == 0 && !stringRenderer_.isWaterfall())
+   {

src/ftinspect/rendering/glyphcontinuous.hpp

@@ -26,6 +26,7 @@ struct GlyphCacheEntry
    QPoint penPos = {};
    int charCode = -1;
    int glyphIndex = -1;
 +  unsigned yPpem = 0;
    FT_Vector advance = {};
@@ -123,10 +124,7 @@ private:
    bool mouseOperationEnabled_ = true;
    int displayingCount_ = 0;
 -  FT_Size_Metrics metrics_;
 -  int x_ = 0, y_ = 0;
 -  int stepY_ = 0;
 -  FT_Pos emboldeningX_, emboldeningY_;
 +  FT_Fixed strokeRadiusForSize_ = 0;
    FT_Matrix shearMatrix_;
    FT_Stroker stroker_;
@@ -152,6 +150,7 @@ private:
    void paintCache(QPainter* painter);
    void fillCache();
    void prePaint();
 +  void updateStroke();
    void updateRendererText();
    void preprocessGlyph(FT_Glyph* glyphPtr);
    void beginSaveLine(FT_Vector pos,

src/ftinspect/widgets/tripletselector.cpp

@@ -436,8 +436,9 @@ TripletSelector::loadTriplet()
+   }
    auto number = engine_->loadFont(fontIndex, faceIndex, instanceIndex);
+-
 -  if (number < 0)
++
 +  // TODO: This may messes up with bitmap-only fonts.
 +  if (!engine_->fontValid())
+   {
      // there might be various reasons why the current
      // (file, face, instance) triplet is invalid or missing;

From:	Charlie Jiang (@cqjjjzr)
Subject:	[Git][freetype/freetype-demos][gsoc-2022-chariri-3] 2 commits: * src/ftinspect/engine/engine.cpp: Support LCD rendering.
Date:	Fri, 19 Aug 2022 14:38:37 +0000