freetype-commit
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[freetype2-demos] master 9ac95b3: [ftinspect] Change unclear comments.


From: Werner Lemberg
Subject: [freetype2-demos] master 9ac95b3: [ftinspect] Change unclear comments.
Date: Mon, 3 Oct 2022 20:29:59 -0400 (EDT)

branch: master
commit 9ac95b3695cd68b983b246a4d2a0bdb17975cc18
Author: Charlie Jiang <w@chariri.moe>
Commit: Charlie Jiang <w@chariri.moe>

    [ftinspect] Change unclear comments.
    
    * src/ftinspect/engine/fontinfo.hpp,
      src/ftinspect/glyphcomponents/glyphcontinuous.cpp: Clearify comments.
    
    * src/ftinspect/maingui.cpp: Actually the left widget does more than
      setting the margin, so the comment line about removing the left widget and
      layout is removed.
---
 src/ftinspect/engine/fontinfo.hpp                 | 2 +-
 src/ftinspect/glyphcomponents/glyphcontinuous.cpp | 3 ++-
 src/ftinspect/maingui.cpp                         | 2 +-
 3 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/src/ftinspect/engine/fontinfo.hpp 
b/src/ftinspect/engine/fontinfo.hpp
index f1cc456..cef35e3 100644
--- a/src/ftinspect/engine/fontinfo.hpp
+++ b/src/ftinspect/engine/fontinfo.hpp
@@ -223,7 +223,7 @@ struct FontFixedSize
   double xPpem;
   double yPpem;
 
-  // Returns that if the list is updated.  WL: ???
+  // Returns `true` when the list is actually updated.
   // We use a callback because Qt needs `beginResetModel` to be called
   // *before* the internal storage updates.
   static bool get(Engine* engine,
diff --git a/src/ftinspect/glyphcomponents/glyphcontinuous.cpp 
b/src/ftinspect/glyphcomponents/glyphcontinuous.cpp
index 440b21e..bdafc9d 100644
--- a/src/ftinspect/glyphcomponents/glyphcontinuous.cpp
+++ b/src/ftinspect/glyphcomponents/glyphcontinuous.cpp
@@ -205,7 +205,8 @@ GlyphContinuous::mouseMoveEvent(QMouseEvent* event)
   {
     positionDelta_ = prevPositionDelta_ + delta;
     positionDelta_.setX(0); // Don't move horizontally.
-    // but use the renderer // WL: ???
+    // The string renderer will handle the horizontal delta. See below.
+    
     // Note the double use of `scale_`: one for undoing `delta /= scale_`,
     // the other one for effectively dividing the width by the scaling
     // factor.
diff --git a/src/ftinspect/maingui.cpp b/src/ftinspect/maingui.cpp
index 1f4ba7d..5c8bd17 100644
--- a/src/ftinspect/maingui.cpp
+++ b/src/ftinspect/maingui.cpp
@@ -267,7 +267,7 @@ MainGUI::createLayout()
   // left side
   settingPanel_ = new SettingPanel(this, engine_);
 
-  leftLayout_ = new QVBoxLayout; // The only point is to set `margin->remove`?
+  leftLayout_ = new QVBoxLayout;
   leftLayout_->addWidget(settingPanel_);
   leftLayout_->setContentsMargins(32, 32, 0, 16);
 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]