gawk-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[SCM] gawk branch, gawk-5.3-stable, updated. gawk-4.1.0-5448-g7af5206b


From: Andrew J. Schorr
Subject: [SCM] gawk branch, gawk-5.3-stable, updated. gawk-4.1.0-5448-g7af5206b
Date: Tue, 16 Jan 2024 10:54:12 -0500 (EST)

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "gawk".

The branch, gawk-5.3-stable has been updated
       via  7af5206b0bc4c72b535703a28035335ed15477ca (commit)
      from  ffad4c6ddb674f71905ccaf06d82ac1cff1118f4 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
http://git.sv.gnu.org/cgit/gawk.git/commit/?id=7af5206b0bc4c72b535703a28035335ed15477ca

commit 7af5206b0bc4c72b535703a28035335ed15477ca
Author: Andrew J. Schorr <aschorr@telemetry-investments.com>
Date:   Tue Jan 16 10:53:42 2024 -0500

    Add a comment to gawkapi.h suggesting that do_flags should be a bitmask if 
we ever change it again.

diff --git a/ChangeLog b/ChangeLog
index c3d878bb..86eef81c 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2024-01-16         Andrew J. Schorr      <aschorr@telemetry-investments.com>
+
+       * gawkapi.h: Add a comment suggesting that do_flags be converted
+       to a bitmask if we ever need to add another value, since the current
+       approach breaks ABI compatibility for each new flag.
+
 2024-01-12         Arnold D. Robbins     <arnold@skeeve.com>
 
        Use newer interfaces for getting the time if they're available.
diff --git a/gawkapi.h b/gawkapi.h
index bf3aba92..a956804a 100644
--- a/gawkapi.h
+++ b/gawkapi.h
@@ -496,6 +496,12 @@ typedef struct gawk_api {
         * These can change on the fly as things happen within gawk.
         * Currently only do_lint is prone to change, but we reserve
         * the right to allow the others to do so also.
+        *
+        * N.B. If we ever again need to add an additional do_flags value,
+        * it would be wise to convert this from an array to a bitmask. If
+        * we add a new do_flags value and bump DO_FLAGS_SIZE, then it requires
+        * us to increment the ABI version. If we use a bitmask instead, then
+        * we will be free to add new flags without breaking ABI compatibility.
         */
 #define DO_FLAGS_SIZE  7
        awk_const int do_flags[DO_FLAGS_SIZE];

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog | 6 ++++++
 gawkapi.h | 6 ++++++
 2 files changed, 12 insertions(+)


hooks/post-receive
-- 
gawk



reply via email to

[Prev in Thread] Current Thread [Next in Thread]