Re: Fix EMS + concat message, cleanup gnokii.c

[Pawel Kot]

On Fri, 7 Jun 2002, Pavel Machek wrote:

> > Bitmaps know NOTHING about UDH. Don't mess it.
>
> They have to. Whole bitmap is in the UDH. Yep, UDH is then 128+
> bytes. I do not want to encode whole bitmap inside EncodeUDH...

No. Pavel, please DO read the specifications first. Bitmap is NOT
UserDataHeader.

> > > diff -u -u -r1.16 gsm-bitmaps.h
> > > --- include/gsm-bitmaps.h 3 Jun 2002 20:30:43 -0000       1.16
> > > +++ include/gsm-bitmaps.h 7 Jun 2002 09:52:14 -0000
> > > @@ -76,7 +76,6 @@
> > >  API void GSM_PrintBitmap(GSM_Bitmap *bitmap);
> > >
> > >  /* SMS bitmap functions */
> > > -int GSM_EncodeSMSBitmap(GSM_Bitmap *bitmap, char *message);
> >
> > Why?
>
> To solve dependency hell. If I try to add GSM_SMSMessage *rawsms in
> the prototype, compilation fails and I'm unable to fix it.

Adding nasty warning is not the solution.

pkot
-- 
mailto:address@hidden :: mailto:address@hidden
http://kt.linuxnews.pl/ :: Kernel Traffic po polsku