Re: [PATCH] Using smsd to send multiline sms

[Jan Derfinak]

On Fri, 18 Jul 2008, Pawel Kot wrote:

> Hi,
> 
> On Fri, Jul 18, 2008 at 15:44, Jan Derfinak <address@hidden> wrote:
> > On Fri, 18 Jul 2008, Pawel Kot wrote:
> >> As the conclusion: I think we should allow sending an empty SMS from
> >> SMSD. So if libgnokii fails with this, I'll fix it. And in the code
> >> above I also think we should allow it.
> >
> > OK. What about attached patch?
> 
> You don't seem to include fgets() -> fread() change. And that would
> make some difference (no need for strlen but instead you need to add
> null termination always).

This is fix for existing bug in smsd. The patch which add multiline SMS
support will be in next mail. In general it is not good practice to mix bug
fixes with new features in one CVS commit.
Please review this patch as bugfix to existing functionality.

jan


--