Re: [PATCH] Using smsd to send multiline sms

[Pawel Kot]

Hi,

On Fri, Jul 18, 2008 at 16:00, Jan Derfinak <address@hidden> wrote:
> This is fix for existing bug in smsd. The patch which add multiline SMS
> support will be in next mail. In general it is not good practice to mix bug
> fixes with new features in one CVS commit.

Yes. You're absolutely right.

> Please review this patch as bugfix to existing functionality.

IMHO memsets are not needed.
I'd also use construction (it's not needed if fgets() in case of
failure sets NULL as the string -- I cannot see this guaranteed in the
manpage):
if (!fgets(...)) {
    sms.something[0] = '\0';
}
slen = ....


pkot
-- 
Pawel Kot