gpsd-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [gpsd-dev] [PATCH] Put udev rules in libdir and not always in /lib


From: Eric S. Raymond
Subject: Re: [gpsd-dev] [PATCH] Put udev rules in libdir and not always in /lib
Date: Tue, 15 Jan 2013 19:34:54 -0500
User-agent: Mutt/1.5.21 (2010-09-15)

Maciej Grela <address@hidden>:
> With both changes applied gpsd now runs correctly when udevdir=/usr/lib64/udev
> What do you think?

It needs polishing.  The way udevdir is set, in your patch, is
spectacularly ugly.  I'm not sure what the right thing is, yet, but
I'm sure it's not that.

I don't understand why you're using installdir().  It doesn't look to me like
we want either DESTDIR or PREFIX in the udevdir path.

I also don't understand where the RUN directives in the rules file get the 
"/lib/udev/" part of the pathname if it's not wired in. Is it documented
that their commands are run with the udev directory current?  If so that
solves the problem, and that part of the patch is good independently of
the rest.

As a step towards something more reasonable, I've pushed a revision that
creates a udevdir config variable with /lib/udev as defaults.
-- 
                <a href="http://www.catb.org/~esr/";>Eric S. Raymond</a>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]